Autosize flex boxes.

Autosize flex boxes.

BUG=341119
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176074

[pdr., 2014-06-11 03:57:05]

LGTM (comment below is outside the scope of this change)

https://codereview.chromium.org/328933002/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderFlexibleBox.cpp (right):

https://codereview.chromium.org/328933002/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderFlexibleBox.cpp:244: FastTextAutosizer::LayoutScope
fastTextAutosizerLayoutScope(this);
If we moved these outside this scope, could we assert(!needsLayout()) in the
LayoutScope destructor?

[skobes, 2014-06-11 21:36:21]

https://codereview.chromium.org/328933002/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderFlexibleBox.cpp (right):

https://codereview.chromium.org/328933002/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderFlexibleBox.cpp:244: FastTextAutosizer::LayoutScope
fastTextAutosizerLayoutScope(this);
On 2014/06/11 03:57:05, pdr wrote:
> If we moved these outside this scope, could we assert(!needsLayout()) in the
> LayoutScope destructor?

Maybe, but I'm not sure why that's useful?

[skobes, 2014-06-11 21:36:57]

FYI this depends on http://crrev.com/324183002, don't check the commit box until
that one lands.

[skobes, 2014-06-12 22:02:42]

The CQ bit was checked by skobes@chromium.org

[commit-bot: I haz the power, 2014-06-12 22:03:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/skobes@chromium.org/328933002/20001

[commit-bot: I haz the power, 2014-06-12 23:18:20]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/11829)

[commit-bot: I haz the power, 2014-06-13 00:29:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-13 00:29:38]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/11835)

[skobes, 2014-06-13 01:25:56]

The CQ bit was checked by skobes@chromium.org

[commit-bot: I haz the power, 2014-06-13 01:26:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/skobes@chromium.org/328933002/20001

[commit-bot: I haz the power, 2014-06-13 02:03:25]

Change committed as 176074