Issue 328923002: Lazy loading of deferred libraries

Issue 328923002: Lazy loading of deferred libraries (Closed)

Created:
6 years, 6 months ago by hausner

Modified:
6 years, 6 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Lazy loading of deferred libraries Defer reading of source code of deferred libraries until the Dart code executes the loadLibrary() call. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=37334

Patch Set 1 #

Patch Set 2 : #

Total comments: 8

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+226 lines, -57 lines)			Patch
M	runtime/bin/bin.gypi	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/builtin.dart	View	1 2 3 4	1 chunk	+57 lines, -14 lines	0 comments	Download
M	runtime/bin/builtin_impl_sources.gypi	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/builtin_natives.cc	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/bin/builtin_sources.gypi	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/dartutils.cc	View	1 2 3 4	3 chunks	+25 lines, -2 lines	0 comments	Download
M	runtime/lib/lib_prefix.dart	View	1 2 3 4	1 chunk	+38 lines, -10 lines	0 comments	Download
M	runtime/lib/mirrors.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/lib/object.cc	View	1 2 3 4	1 chunk	+10 lines, -2 lines	0 comments	Download
M	runtime/vm/benchmark_test.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/bootstrap.cc	View	1 2 3 4	2 chunks	+2 lines, -1 line	0 comments	Download
M	runtime/vm/bootstrap_natives.h	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1 2 3 4	3 chunks	+7 lines, -4 lines	0 comments	Download
M	runtime/vm/object.h	View	1 2 3 4	5 chunks	+9 lines, -2 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 2 3 4	12 chunks	+56 lines, -9 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1 2 3 4	2 chunks	+13 lines, -8 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	1 2 3 4	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

First round of comments. -Ivan https://codereview.chromium.org/328923002/diff/20001/runtime/bin/dartutils.cc File runtime/bin/dartutils.cc (right): https://codereview.chromium.org/328923002/diff/20001/runtime/bin/dartutils.cc#newcode682 runtime/bin/dartutils.cc:682: if (Dart_IsError(result)) Dart_PropagateError(result); {} ...

6 years, 6 months ago (2014-06-12 23:05:11 UTC) #2

hausner

All taken care of. https://codereview.chromium.org/328923002/diff/20001/runtime/bin/dartutils.cc File runtime/bin/dartutils.cc (right): https://codereview.chromium.org/328923002/diff/20001/runtime/bin/dartutils.cc#newcode682 runtime/bin/dartutils.cc:682: if (Dart_IsError(result)) Dart_PropagateError(result); On 2014/06/12 ...

6 years, 6 months ago (2014-06-12 23:54:37 UTC) #3

Ivan Posva

LGTM We should address the concurrent loading of libraries from different prefixes in a follow ...

6 years, 6 months ago (2014-06-13 18:26:39 UTC) #4

hausner

Thank you. https://codereview.chromium.org/328923002/diff/60001/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): https://codereview.chromium.org/328923002/diff/60001/runtime/vm/dart_api_impl.cc#newcode4980 runtime/vm/dart_api_impl.cc:4980: } else if (!(library.LoadNotStarted() || library.LoadRequested())) { ...

6 years, 6 months ago (2014-06-13 22:41:57 UTC) #5

hausner

6 years, 6 months ago (2014-06-13 22:43:41 UTC) #6

Message was sent while issue was closed.

Committed patchset #5 manually as r37334 (presubmit successful).

Expand Messages | Collapse Messages