net/socket/ssl_session_cache_openssl.h - Issue 328903004: SSL Connect Job Waiting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/ssl_session_cache_openssl.h

Issue 328903004: SSL Connect Job Waiting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Redesigned cache accessing functions. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/ssl_session_cache_openssl.h

diff --git a/net/socket/ssl_session_cache_openssl.h b/net/socket/ssl_session_cache_openssl.h

index bbd9659641df062dc870880f805031006deddb59..5a867a87d468010b51b5c272c478bdd1088b15ba 100644

--- a/net/socket/ssl_session_cache_openssl.h

+++ b/net/socket/ssl_session_cache_openssl.h

@@ -113,6 +113,9 @@ class NET_EXPORT SSLSessionCacheOpenSSL {

// Return true iff a cached session was associated with the |ssl| connection.

bool SetSSLSessionWithKey(SSL* ssl, const std::string& cache_key);

+ // Return true iff a cached session was associated with the given |cache_key|.

+ bool SessionIsInCache(const std::string& cache_key) const;

wtc 2014/06/17 17:44:41 Nit: add "SSL" before "Session" because the other

mshelley1 2014/06/18 18:53:51 Done.

// Indicates that the SSL session associated with |ssl| is "good" - that is,

// that all associated cryptographic parameters that were negotiated,

// including the peer's certificate, were successfully validated. Because