SSL Connect Job Waiting

net/socket/ssl_client_socket.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_SOCKET_SSL_CLIENT_SOCKET_H_
 #define NET_SOCKET_SSL_CLIENT_SOCKET_H_
 
 #include <string>
 
 #include "base/gtest_prod_util.h"
@@ skipping 63 matching lines @@
     kNextProtoUnsupported = 0,  // The server doesn't support NPN.
     kNextProtoNegotiated = 1,   // We agreed on a protocol.
     kNextProtoNoOverlap = 2,    // No protocols in common. We requested
                                 // the first protocol in our list.
   };
 
   // StreamSocket:
   virtual bool WasNpnNegotiated() const OVERRIDE;
   virtual NextProto GetNegotiatedProtocol() const OVERRIDE;
 
+  // Returns true if there is a cache entry in the ssl session cache
+  // for the given |cache key|.
+  //
+  // |cache_key| consists of an SSLConnectJobs host_and_port name
+  // concatenated with its session cache shard.

[wtc, 2014/06/19 19:38:10]

Since this method doesn't have a |cache_key| parameter, change "|cache key|" and
"|cache_key|" to just "cache key".

The "|...|" notation is to simulate a code font, so the text inside the || is a
piece of code, usually a variable or function parameter name.

"SSLConnectJobs host_and_port name" also needs work. Definitely remove the
reference to SSLConnectJob. I think we can just say:

  The cache key consists of a host_and_port concatenated with a session cache
shard.

[mshelley1, 2014/06/24 17:03:59]

Done.

+  virtual bool InSessionCache() const;

[wtc, 2014/06/19 19:38:10]

Could you declare this virtual method as abstract (= 0)?

[mshelley1, 2014/06/24 17:03:59]

Done.

+
   // Gets the SSL CertificateRequest info of the socket after Connect failed
   // with ERR_SSL_CLIENT_AUTH_CERT_NEEDED.
   virtual void GetSSLCertRequestInfo(
       SSLCertRequestInfo* cert_request_info) = 0;
 
   // Get the application level protocol that we negotiated with the server.
   // *proto is set to the resulting protocol (n.b. that the string may have
   // embedded NULs).
   //   kNextProtoUnsupported: *proto is cleared.
   //   kNextProtoNegotiated:  *proto is set to the negotiated protocol.
@@ skipping 89 matching lines @@
   bool channel_id_sent_;
   // True if SCTs were received via a TLS extension.
   bool signed_cert_timestamps_received_;
   // True if a stapled OCSP response was received.
   bool stapled_ocsp_response_received_;
 };
 
 }  // namespace net
 
 #endif  // NET_SOCKET_SSL_CLIENT_SOCKET_H_