Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 328903002: Factor out a BluetoothChannelMac base class and a BluetoothRfcommChannelMac subclass. (Closed)

Created:
6 years, 6 months ago by Ilya Sherman
Modified:
6 years, 6 months ago
Reviewers:
keybuk
CC:
chromium-reviews, armansito, xiyuan
Visibility:
Public.

Description

Factor out a BluetoothChannelMac base class and a BluetoothRfcommChannelMac subclass. These will allow the BluetoothSocketMac code to treat RFCOMM and L2CAP channels uniformly, abstracting any differences via the BluetoothChannelMac class. BUG=372495 TEST=BluetoothTest app R=keybuk@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276647

Patch Set 1 #

Patch Set 2 : git-add new files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+395 lines, -160 lines) Patch
M device/bluetooth/bluetooth.gyp View 2 chunks +4 lines, -0 lines 0 comments Download
A device/bluetooth/bluetooth_channel_mac.h View 1 chunk +59 lines, -0 lines 0 comments Download
A device/bluetooth/bluetooth_channel_mac.mm View 1 chunk +22 lines, -0 lines 0 comments Download
A device/bluetooth/bluetooth_rfcomm_channel_mac.h View 1 1 chunk +67 lines, -0 lines 0 comments Download
A device/bluetooth/bluetooth_rfcomm_channel_mac.mm View 1 1 chunk +168 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_socket_mac.h View 5 chunks +14 lines, -21 lines 0 comments Download
M device/bluetooth/bluetooth_socket_mac.mm View 20 chunks +61 lines, -139 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
Ilya Sherman
keybuk: owner review rpaquay, armansito, xiyuan: FYI and extra eyes
6 years, 6 months ago (2014-06-10 22:33:06 UTC) #1
keybuk
lgtm
6 years, 6 months ago (2014-06-10 22:45:52 UTC) #2
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 6 months ago (2014-06-10 22:57:46 UTC) #3
rpaquay
On 2014/06/10 22:33:06, Ilya Sherman wrote: > keybuk: owner review > rpaquay, armansito, xiyuan: FYI ...
6 years, 6 months ago (2014-06-10 22:59:36 UTC) #4
Ilya Sherman
The CQ bit was unchecked by isherman@chromium.org
6 years, 6 months ago (2014-06-10 23:00:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/328903002/1
6 years, 6 months ago (2014-06-10 23:00:27 UTC) #6
Ilya Sherman
On 2014/06/10 22:59:36, rpaquay wrote: > On 2014/06/10 22:33:06, Ilya Sherman wrote: > > keybuk: ...
6 years, 6 months ago (2014-06-10 23:04:23 UTC) #7
Ilya Sherman
(keybuk, please take another look -- CL now has the shiny new files git-added)
6 years, 6 months ago (2014-06-10 23:04:52 UTC) #8
keybuk
lgtm
6 years, 6 months ago (2014-06-11 20:17:30 UTC) #9
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 6 months ago (2014-06-11 20:19:00 UTC) #10
Ilya Sherman
The CQ bit was unchecked by isherman@chromium.org
6 years, 6 months ago (2014-06-11 20:19:15 UTC) #11
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 6 months ago (2014-06-11 20:19:16 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/328903002/20001
6 years, 6 months ago (2014-06-11 20:20:21 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 21:38:24 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 21:41:03 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/160359) ios_rel_device on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds/149777) ios_rel_device_ninja ...
6 years, 6 months ago (2014-06-11 21:41:04 UTC) #16
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 6 months ago (2014-06-12 08:39:28 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/328903002/20001
6 years, 6 months ago (2014-06-12 08:42:22 UTC) #18
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 12:59:22 UTC) #19
Message was sent while issue was closed.
Change committed as 276647

Powered by Google App Engine
This is Rietveld 408576698