Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(856)

Unified Diff: build/java.gypi

Issue 328893003: Make javac and jar a single build action (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/java.gypi
diff --git a/build/java.gypi b/build/java.gypi
index 641dc7799f47a055e4f58692a5c523dac7f13e64..966d395386d351530fcbd015f326a9d91cbb7866 100644
--- a/build/java.gypi
+++ b/build/java.gypi
@@ -230,14 +230,17 @@
],
'outputs': [
'<(compile_stamp)',
+ '<(javac_jar_path)',
],
'action': [
'python', '<(DEPTH)/build/android/gyp/javac.py',
- '--output-dir=<(classes_dir)',
+ '--classes-dir=<(classes_dir)',
'--classpath=>(input_jars_paths)',
'--src-gendirs=>(generated_src_dirs)',
'--javac-includes=<(javac_includes)',
'--chromium-code=<(chromium_code)',
+ '--jar-path=<(javac_jar_path)',
+ '--jar-excluded-classes=<(jar_excluded_classes)',
'--stamp=<(compile_stamp)',
'>@(java_sources)',
]
@@ -261,25 +264,6 @@
'includes': [ 'android/lint_action.gypi' ],
},
{
- 'action_name': 'jar_<(_target_name)',
- 'message': 'Creating <(_target_name) jar',
- 'inputs': [
- '<(DEPTH)/build/android/gyp/util/build_utils.py',
- '<(DEPTH)/build/android/gyp/util/md5_check.py',
- '<(DEPTH)/build/android/gyp/jar.py',
- '<(compile_stamp)',
- ],
- 'outputs': [
- '<(javac_jar_path)',
- ],
- 'action': [
- 'python', '<(DEPTH)/build/android/gyp/jar.py',
- '--classes-dir=<(classes_dir)',
- '--jar-path=<(javac_jar_path)',
- '--excluded-classes=<(jar_excluded_classes)',
- ]
- },
- {
'action_name': 'instr_jar_<(_target_name)',
'message': 'Instrumenting <(_target_name) jar',
'variables': {
« no previous file with comments | « build/android/gyp/util/build_utils.py ('k') | build/java_apk.gypi » ('j') | build/java_apk.gypi » ('J')

Powered by Google App Engine
This is Rietveld 408576698