Issue 328883005: Fix GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 328883005: Fix GN build. (Closed)

Created:
6 years, 6 months ago by Michael Starzinger

Modified:
6 years, 6 months ago

Reviewers:
Michael Achenbach

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	BUILD.gn	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Michael Starzinger

Highly complex CL, for a deep technical issue.

6 years, 6 months ago (2014-06-11 08:07:31 UTC) #1

Michael Achenbach

After intensive and thorough review I decided to give you an lgtm!

6 years, 6 months ago (2014-06-11 08:28:07 UTC) #2

Michael Starzinger

6 years, 6 months ago (2014-06-11 08:31:29 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r21759 (presubmit successful).