Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 328883003: Fix what I just broke (Closed)

Created:
6 years, 6 months ago by kelvinly
Modified:
6 years, 6 months ago
Reviewers:
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Merge fixed now? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M bench/gen_bench_expectations.py View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
kelvinly
Left in merge marking stuff in the last commit, using this one to fix that
6 years, 6 months ago (2014-06-10 22:28:31 UTC) #1
kelvinly
The CQ bit was checked by kelvinly@google.com
6 years, 6 months ago (2014-06-10 22:28:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kelvinly@google.com/328883003/1
6 years, 6 months ago (2014-06-10 22:29:36 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-10 22:29:37 UTC) #4
commit-bot: I haz the power
Failed to apply patch for bench/gen_bench_expectations.py: While running git apply --index -p1; error: patch failed: ...
6 years, 6 months ago (2014-06-10 22:29:38 UTC) #5
kelvinly
The CQ bit was checked by kelvinly@google.com
6 years, 6 months ago (2014-06-10 22:32:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kelvinly@google.com/328883003/20001
6 years, 6 months ago (2014-06-10 22:32:37 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 22:32:49 UTC) #8
Message was sent while issue was closed.
Change committed as 5a220a1f479f02676bc1a92fea0b2cc2556ec4f9

Powered by Google App Engine
This is Rietveld 408576698