Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: mojo/services/public/interfaces/view_manager/view_manager.mojom

Issue 328873002: Renames view manager Connect methods to Embed (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: mispelling Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/public/interfaces/view_manager/view_manager.mojom
diff --git a/mojo/services/public/interfaces/view_manager/view_manager.mojom b/mojo/services/public/interfaces/view_manager/view_manager.mojom
index f2781b288698f8096b56a14374657874d7eeafe0..4d03bd25e9a7120c2992bfbdae7a6455a8221699 100644
--- a/mojo/services/public/interfaces/view_manager/view_manager.mojom
+++ b/mojo/services/public/interfaces/view_manager/view_manager.mojom
@@ -18,8 +18,7 @@ struct INode {
// root node. mojo::view_manager returns an instance of this. All other
// connections are established by the client this creates.
interface IViewManagerInit {
- // Connects to |url| creating a connection that has the roots |nodes|.
- Connect(string url) => (bool success);
+ EmbedRoot(string url) => (bool success);
};
// Functions that mutate the hierarchy take a change id. This is an ever
@@ -97,13 +96,15 @@ interface IViewManager {
handle<shared_buffer> buffer,
uint32 buffer_size) => (bool success);
- // Connects to |url| creating a connection that has the roots |nodes|. Fails
+ // Embeds the app at |url| in the specified nodes. More specifically this
+ // creates a new connection to the specified url, expecting to get an
+ // IViewManagerClient and configures it with the root nodes |nodes|. Fails
// if |nodes| is empty or contains nodes that were not created by this
// connection.
- // If a particular client invokes Connect() multiple times with the same url,
+ // If a particular client invokes Embed() multiple times with the same url,
// the connection is reused. When this happens the IViewManagerClient is
// notified of the additional roots by way of OnRootsAdded().
- Connect(string url, uint32[] nodes) => (bool success);
+ Embed(string url, uint32[] nodes) => (bool success);
};
// Changes to nodes/views are not sent to the connection that originated the
« no previous file with comments | « mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc ('k') | mojo/services/view_manager/root_node_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698