gclient.py - Issue 328843005: Consolidated 'git' refish parsing into a class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gclient.py

Issue 328843005: Consolidated 'git' refish parsing into a class (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Updated w/ nits, added new case(s) to refish parsing Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gclient.py

diff --git a/gclient.py b/gclient.py

index 6a7b0e477d939508e25a00884e39889f16b596a8..f209eab6557e8a49d1b8f8804e06fe107a67ceea 100755

--- a/gclient.py

+++ b/gclient.py

@@ -1079,7 +1079,7 @@ solutions = [

if dep.managed and dep.url:

scm = gclient_scm.CreateSCM(

dep.url, self.root_dir, dep.name, self.outbuf)

- actual_url = scm.GetActualRemoteURL(self._options)

+ actual_url = scm.GetActualRemoteURL()

if actual_url and not scm.DoesRemoteURLMatch(self._options):

raise gclient_utils.Error('''

Your .gclient file seems to be broken. The requested URL is different from what

« no previous file with comments | « no previous file | gclient_scm.py » ('j') | gclient_scm.py » ('J')