Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 32883002: Merge 229567 "android: fix base::Time::FromLocalExploded() crash." (Closed)

Created:
7 years, 2 months ago by kerz_chromium
Modified:
7 years, 2 months ago
Reviewers:
digit1
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Merge 229567 "android: fix base::Time::FromLocalExploded() crash." > android: fix base::Time::FromLocalExploded() crash. > > This patch does the following: > > - Provide a work-around for an Android platform bug that > happens on older Android releases (e.g. 4.1.2), but fixed > on later ones (e.g. 4.3), where mktime() / mktime64() > would return -1 even when passed proper time values. > > - Improve the code to properly deal with the fact that > SysTime is actually int64 on Android, unlike other > platforms, allowing us to remove the CHECK() that > was triggered by the platform bug. > > - Add a new unit test to verify that the new code > doesn't crash on Android 4.1.2 anymore, and returns > the correct values. > > BUG=287821 > R=jar@chromium.org,mark@chromium.org,brettw@chromium.org > > Review URL: https://codereview.chromium.org/27472003 TBR=digit@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229824

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -7 lines) Patch
M base/time/time_posix.cc View 2 chunks +44 lines, -7 lines 0 comments Download
M base/time/time_unittest.cc View 2 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kerz_chromium
7 years, 2 months ago (2013-10-21 16:19:55 UTC) #1
kerz_chromium
7 years, 2 months ago (2013-10-21 16:20:24 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r229824.

Powered by Google App Engine
This is Rietveld 408576698