Chromium Code Reviews
DescriptionMerge 229567 "android: fix base::Time::FromLocalExploded() crash."
> android: fix base::Time::FromLocalExploded() crash.
>
> This patch does the following:
>
> - Provide a work-around for an Android platform bug that
> happens on older Android releases (e.g. 4.1.2), but fixed
> on later ones (e.g. 4.3), where mktime() / mktime64()
> would return -1 even when passed proper time values.
>
> - Improve the code to properly deal with the fact that
> SysTime is actually int64 on Android, unlike other
> platforms, allowing us to remove the CHECK() that
> was triggered by the platform bug.
>
> - Add a new unit test to verify that the new code
> doesn't crash on Android 4.1.2 anymore, and returns
> the correct values.
>
> BUG=287821
> R=jar@chromium.org,mark@chromium.org,brettw@chromium.org
>
> Review URL: https://codereview.chromium.org/27472003
TBR=digit@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229824
Patch Set 1 #
Messages
Total messages: 2 (0 generated)
|
||||||||||||||||||||||||||||