Add wifi AP info to system profile metrics

net/base/wifi_access_point_info_provider_stub.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Stub implementation for non-chromeos platforms.
+#if !defined(OS_CHROMEOS)
+#include "net/base/wifi_access_point_info_provider.h"
+
+namespace net {
+
+// Stub implementation of the WifiAccessPointInfoProvider interface.
+class WifiAccessPointInfoProviderStub : public WifiAccessPointInfoProvider {
+ public:
+  WifiAccessPointInfoProviderStub() {}
+  virtual ~WifiAccessPointInfoProviderStub() {}
+
+  virtual bool GetInfo(net::WifiAccessPointInfo *info)
+      OVERRIDE {

[stevenjb, 2014/07/23 20:03:36]

One line

[zqiu1, 2014/07/23 21:48:40]

Done.

+    NOTIMPLEMENTED();
+    return false;
+  }
+};
+
+// static
+scoped_ptr<WifiAccessPointInfoProvider> WifiAccessPointInfoProvider::Create() {
+  return scoped_ptr<WifiAccessPointInfoProvider>(
+      new WifiAccessPointInfoProviderStub());
+}

[stevenjb, 2014/07/23 20:03:36]

So, this mechanism of using a static Create method shouldn't be used across
libraries (net/ and chromeos/). When I recommended it I didn't think about hte
fact that net/ can't depend on chromeos/ so the cros impl needs to be in
chromeos/.

Instead, just have the calling code construct either the Chromeos or Stub
version using #idfefs.

Also, rather than #ifdef out the entire file just include the code on all
platforms. (Normally you would just #ifdef out the Create() method, but as
mentioned we shouldn't use that here).

[zqiu1, 2014/07/23 21:48:40]

Done.

+
+} // namespace net
+#endif // OS_CHROMEOS