Clean up PointIsClippedBySurfaceOrClipRect

cc/trees/layer_tree_impl_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/trees/layer_tree_impl.h"
 
 #include "cc/layers/heads_up_display_layer_impl.h"
 #include "cc/layers/layer.h"
 #include "cc/test/fake_impl_proxy.h"
 #include "cc/test/fake_layer_tree_host_impl.h"
@@ skipping 1099 matching lines @@
 
   // At (20, 51), child1 and grand_child1 overlap. grand_child1 is expected to
   // be on top.
   test_point = gfx::Point(20, 51);
   result_layer =
       host_impl().active_tree()->FindLayerThatIsHitByPoint(test_point);
   ASSERT_TRUE(result_layer);
   EXPECT_EQ(4, result_layer->id());
 }
 
+TEST_F(LayerTreeImplTest, HitTestingNotDrawnClippedLayersWithHandlers) {
+  scoped_ptr<LayerImpl> root = LayerImpl::Create(host_impl().active_tree(), 1);
+  gfx::Transform identity_matrix;
+  gfx::Point3F transform_origin;
+  gfx::PointF position;
+  gfx::Size bounds(100, 100);
+  SetLayerPropertiesForTesting(root.get(),
+                               identity_matrix,
+                               transform_origin,
+                               position,
+                               bounds,
+                               true,
+                               false);
+  root->SetDrawsContent(true);
+  {
+    scoped_ptr<LayerImpl> child1 =
+        LayerImpl::Create(host_impl().active_tree(), 2);
+    scoped_ptr<LayerImpl> grand_child1 =
+        LayerImpl::Create(host_impl().active_tree(), 4);
+
+    position = gfx::PointF(10.f, 10.f);
+    bounds = gfx::Size(50, 50);
+    SetLayerPropertiesForTesting(child1.get(),
+                                 identity_matrix,
+                                 transform_origin,
+                                 position,
+                                 bounds,
+                                 true,
+                                 false);
+    child1->SetDrawsContent(true);
+    child1->SetMasksToBounds(true);
+
+    position = gfx::PointF(0.f, 40.f);
+    bounds = gfx::Size(100, 50);
+    SetLayerPropertiesForTesting(grand_child1.get(),
+                                 identity_matrix,
+                                 transform_origin,
+                                 position,
+                                 bounds,
+                                 true,
+                                 false);
+    grand_child1->SetDrawsContent(true);
+    grand_child1->SetForceRenderSurface(true);
+
+    child1->AddChild(grand_child1.Pass());
+    root->AddChild(child1.Pass());
+  }
+
+  LayerImpl* child1 = root->children()[0];
+  LayerImpl* grand_child1 = child1->children()[0];
+
+  child1->SetTouchEventHandlerRegion(gfx::Rect(0, 0, 50, 50));
+  grand_child1->SetTouchEventHandlerRegion(gfx::Rect(0, 0, 50, 50));
+
+  host_impl().SetViewportSize(root->bounds());
+  host_impl().active_tree()->SetRootLayer(root.Pass());
+  host_impl().active_tree()->UpdateDrawProperties();
+
+  // This is meant to simulate the destruction of the render target. In
+  // reality this would leave a stale pointer, but to ensure that the test
+  // crashes without the appropriate guards, we force it to be NULL here.
+  child1->draw_properties().render_target = NULL;
+  child1->SetHideLayerAndSubtree(true);
+  host_impl().active_tree()->UpdateDrawProperties();
+
+  gfx::Point test_point = gfx::Point(11, 51);
+  LayerImpl* result_layer =
+      host_impl().active_tree()->FindLayerThatIsHitByPoint(test_point);
+  ASSERT_TRUE(result_layer);
+  EXPECT_EQ(4, result_layer->id());

[danakj, 2014/06/11 22:15:06]

Mmh, you're touch-interacting with grandchild1, but the whole subtree is hidden?
That sounds weird.. is that what you really want?

I should point out that SetHideLayerAndSubtree() is currently never used by
blink only by the browser compositor, so I'm not sure if this is testing what
you mean it to.

[Ian Vollick, 2014/06/11 23:50:37]

It is weird, but yeah, it was intentional. We still need to detect bits of the
tree with touch handlers even if they're not drawn.
 
This was one of a few ways I could make SubtreeShouldBeSkipped return true. I've
switched it to opacity = 0.

[danakj, 2014/06/12 00:21:23]

Well, hm. Isn't the invariant that you have a valid transform if you have a
descendant that draws? But if you're touching a leaf node that doesn't draw,
then how do you know it or any ancestor have a valid transform?

+}
+
 TEST_F(LayerTreeImplTest, HitTestingForMultipleLayerLists) {
   //
   // The geometry is set up similarly to the previous case, but
   // all layers are forced to be render surfaces now.
   //
   scoped_ptr<LayerImpl> root = LayerImpl::Create(host_impl().active_tree(), 1);
 
   gfx::Transform identity_matrix;
   gfx::Point3F transform_origin;
   gfx::PointF position;
@@ skipping 797 matching lines @@
 
   test_point = gfx::Point(35, 65);
   result_layer =
       host_impl().active_tree()->FindLayerThatIsHitByPointInTouchHandlerRegion(
           test_point);
   EXPECT_FALSE(result_layer);
 }
 
 }  // namespace
 }  // namespace cc