Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: runtime/vm/compiler.cc

Issue 328743003: Update use lists after eliminating redundant phis. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: addressed comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/flow_graph_optimizer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/compiler.cc
===================================================================
--- runtime/vm/compiler.cc (revision 37223)
+++ runtime/vm/compiler.cc (working copy)
@@ -479,6 +479,7 @@
optimizer.EliminateEnvironments();
DeadCodeElimination::EliminateDeadPhis(flow_graph);
+ DEBUG_ASSERT(flow_graph->VerifyUseLists());
Ivan Posva 2014/06/11 15:20:50 What exactly is a DEBUG_ASSERT and why is it being
Florian Schneider 2014/06/11 15:30:31 // DEBUG_ASSERT allows identifiers in condition to
Ivan Posva 2014/06/11 16:25:24 See followup CL, which removes the unnecessary use
// Attempt to sink allocations of temporary non-escaping objects to
// the deoptimization path.
@@ -489,6 +490,7 @@
sinking = new AllocationSinking(flow_graph);
sinking->Optimize();
}
+ DEBUG_ASSERT(flow_graph->VerifyUseLists());
// Ensure that all phis inserted by optimization passes have consistent
// representations.
« no previous file with comments | « no previous file | runtime/vm/flow_graph_optimizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698