Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 328723002: Timeline: add disabled-by-default-devtools.timeline{,.frame} to category filter (Closed)

Created:
6 years, 6 months ago by caseq
Modified:
6 years, 6 months ago
Reviewers:
yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Timeline: add disabled-by-default-devtools.timeline{,.frame} to category filter This prepares inspector for switching chromium-side trace events used for building timeline to the category names consistent with the rest of timeline trace-based instrumentation in blink. BUG=361045 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175891

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/core/inspector/TraceEventDispatcher.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TracingTimelineModel.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
caseq
6 years, 6 months ago (2014-06-10 11:41:03 UTC) #1
yurys
lgtm
6 years, 6 months ago (2014-06-10 11:53:04 UTC) #2
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 6 months ago (2014-06-10 12:02:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/328723002/1
6 years, 6 months ago (2014-06-10 12:03:29 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 13:16:29 UTC) #5
Message was sent while issue was closed.
Change committed as 175891

Powered by Google App Engine
This is Rietveld 408576698