Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 328703005: Use ScriptWrappable::init less (Closed)

Created:
6 years, 6 months ago by rwlbuis
Modified:
6 years, 6 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, fs, kouhei+svg_chromium.org, dstockwell, Timothy Loh, krit, f(malita), gyuyoung.kim_webkit.org, darktears, Stephen Chennney, Steve Block, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Use ScriptWrappable::init less Use ScriptWrappable::init less, it is only needed for most derived classes usually, but these SVG classes are not exposed as JS type. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176073

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M Source/core/svg/SVGAnimationElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGGradientElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGPathSeg.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGTextContentElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGTextPositioningElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
rwlbuis
PTAL
6 years, 6 months ago (2014-06-10 19:16:17 UTC) #1
pdr.
On 2014/06/10 19:16:17, rwlbuis wrote: > PTAL I don't feel comfortable reviewing this one as ...
6 years, 6 months ago (2014-06-12 17:30:34 UTC) #2
kouhei (in TOK)
+cc: haraken FYI. lgtm
6 years, 6 months ago (2014-06-13 00:30:07 UTC) #3
kouhei (in TOK)
6 years, 6 months ago (2014-06-13 00:30:28 UTC) #4
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 6 months ago (2014-06-13 00:30:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/328703005/1
6 years, 6 months ago (2014-06-13 00:31:02 UTC) #6
rwlbuis
On 2014/06/13 00:30:07, kouhei wrote: > +cc: haraken FYI. > > lgtm Thanks! BTW I ...
6 years, 6 months ago (2014-06-13 00:48:36 UTC) #7
haraken
LGTM. We're planning to remove ScriptWrappable::init in the future :)
6 years, 6 months ago (2014-06-13 00:50:12 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-13 01:15:15 UTC) #9
Message was sent while issue was closed.
Change committed as 176073

Powered by Google App Engine
This is Rietveld 408576698