Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 328663010: Simplify ServiceWorkerContainer's access to its window. (Closed)

Created:
6 years, 6 months ago by dominicc (has gone to gerrit)
Modified:
6 years, 6 months ago
Reviewers:
michaeln
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org, alecflett+watch_chromium.org
Visibility:
Public.

Description

Simplify ServiceWorkerContainer's access to its window. Actually two refactorings for navigator.serviceWorker.ready which is sensitive to lifetimes. No change in behavior. First, ServiceWorkerContainer is a DOMWindowLifecycleObserver to access a window for postMessage. But it already has an execution context that can provide the DOMWindow. Use that instead. Second, adds an unrelated assertion that the container's ServiceWorkerContainerClient has been cleaned up by the time that the container is deleted. To do otherwise is to leave the ServiceWorkerContainerClient with a dangling pointer to the container. BUG=363967 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175973

Patch Set 1 #

Patch Set 2 : Bring patch to head. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M Source/modules/serviceworkers/ServiceWorkerContainer.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dominicc (has gone to gerrit)
PTAL Basically clean-up ahead of making .ready work for the waiting Service Worker.
6 years, 6 months ago (2014-06-10 22:00:05 UTC) #1
michaeln
lgtm
6 years, 6 months ago (2014-06-10 23:46:50 UTC) #2
dominicc (has gone to gerrit)
The CQ bit was checked by dominicc@chromium.org
6 years, 6 months ago (2014-06-11 18:06:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/328663010/20001
6 years, 6 months ago (2014-06-11 18:07:02 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 19:17:40 UTC) #5
Message was sent while issue was closed.
Change committed as 175973

Powered by Google App Engine
This is Rietveld 408576698