Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: runtime/vm/exceptions_test.cc

Issue 328663008: Add support to trace warnings in TraceBuffer. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/exceptions.cc ('k') | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/exceptions_test.cc
===================================================================
--- runtime/vm/exceptions_test.cc (revision 37297)
+++ runtime/vm/exceptions_test.cc (working copy)
@@ -132,4 +132,52 @@
EXPECT_VALID(Dart_Invoke(lib, NewString("testMain"), 0, NULL));
}
+
+TEST_CASE(TraceJSWarning) {
+ Isolate* isolate = Isolate::Current();
+ TraceBuffer::Init(isolate, 3);
+ TraceBuffer* trace_buffer = isolate->trace_buffer();
+ const String& url = String::Handle(isolate, String::New("Plug"));
+ const String& source = String::Handle(isolate, String::New("240V"));
+ const Script& script = Script::Handle(isolate,
+ Script::New(url, source, RawScript::kScriptTag));
+ {
+ const intptr_t token_pos = 0;
+ const char* message = "High Voltage";
+ Exceptions::TraceJSWarningF(script, token_pos, "%s", message);
+ {
+ JSONStream js;
+ trace_buffer->PrintToJSONStream(&js);
+ EXPECT_SUBSTRING("{\"type\":\"TraceBuffer\",\"members\":["
+ "{\"type\":\"TraceBufferEntry\",\"time\":",
+ js.ToCString());
+ // Skip time.
+ EXPECT_SUBSTRING("\"message\":{\"type\":\"JSCompatibilityWarning\","
+ "\"script\":{\"type\":\"@Script\",\"id\":"
+ "\"scripts\\/Plug\",\"name\":\"Plug\",\"user_name\":"
+ "\"Plug\",\"kind\":\"script\"},\"tokenPos\":0,"
+ "\"message\":\"High Voltage\"}}]}",
+ js.ToCString());
+ }
+ }
+ {
+ const intptr_t token_pos = 1;
+ const char* message = "Low Voltage";
+ Exceptions::TraceJSWarningF(script, token_pos, "%s", message);
+ }
+ EXPECT_EQ(2, trace_buffer->Length());
+ EXPECT_STREQ("{\"type\":\"JSCompatibilityWarning\",\"script\":{\"type\":"
+ "\"@Script\",\"id\":\"scripts\\/Plug\",\"name\":\"Plug\","
+ "\"user_name\":\"Plug\",\"kind\":\"script\"},\"tokenPos\":0,"
+ "\"message\":\"High Voltage\"}",
+ trace_buffer->At(0)->message);
+ EXPECT_STREQ("{\"type\":\"JSCompatibilityWarning\",\"script\":{\"type\":"
+ "\"@Script\",\"id\":\"scripts\\/Plug\",\"name\":\"Plug\","
+ "\"user_name\":\"Plug\",\"kind\":\"script\"},\"tokenPos\":1,"
+ "\"message\":\"Low Voltage\"}",
+ trace_buffer->At(1)->message);
+
+ delete trace_buffer;
+}
+
} // namespace dart
« no previous file with comments | « runtime/vm/exceptions.cc ('k') | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698