Add support to trace warnings in TraceBuffer.

runtime/vm/trace_buffer_test.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/assert.h"
 #include "vm/globals.h"
 #include "vm/json_stream.h"
 #include "vm/trace_buffer.h"
 #include "vm/unit_test.h"
 
@@ skipping 86 matching lines @@
   trace_buffer->TraceF("foo %d %s", 99, "bar");
   {
     JSONStream js;
     trace_buffer->PrintToJSONStream(&js);
     EXPECT_SUBSTRING("foo 99 bar", js.ToCString());
   }
   delete trace_buffer;
 }
 
 
+TEST_CASE(TraceBufferTraceWarning) {
+  Isolate* isolate = Isolate::Current();
+  TraceBuffer::Init(isolate, 3);
+  TraceBuffer* trace_buffer = isolate->trace_buffer();
+  const String& url = String::Handle(isolate, String::New("Plug"));
+  const String& source = String::Handle(isolate, String::New("240V"));
+  const Script& script = Script::Handle(isolate,
+      Script::New(url, source, RawScript::kScriptTag));
+  const intptr_t token_pos = 0;
+  const char* message = "High Voltage";
+  TraceBuffer::TraceWarningF(isolate, script, token_pos, "%s", message);
+  {
+    JSONStream js;
+    trace_buffer->PrintToJSONStream(&js);

[Cutch, 2014/06/11 21:45:03]

For testing, we could add accessors:

At(intptr_t i) const;
intptr_t Length() const;

to TraceBuffer.

[regis, 2014/06/11 23:48:35]

Done.

+    EXPECT_SUBSTRING("{\"type\":\"TraceBuffer\",\"members\":["
+                     "{\"type\":\"TraceBufferEntry\",\"time\":",
+                     js.ToCString());
+    // Skip time.
+    EXPECT_SUBSTRING("\"message\":\"{\\\"type\\\":\\\"TraceBufferWarning\\\","
+                     "\\\"script_url\\\":\\\"Plug\\\",\\\"token_pos\\\":0,"

[Cutch, 2014/06/11 21:45:03]

Please also add a test that exercises PrintToJSONStream

[regis, 2014/06/11 23:48:35]

Done.

+                     "\\\"message\\\":\\\"High Voltage\\\"\"}]}",
+                     js.ToCString());
+  }
+  delete trace_buffer;
+}
+
 }  // namespace dart