Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 328663005: Revert of Add colorama to third_party/colorama (Closed)

Created:
6 years, 6 months ago by alph
Modified:
6 years, 6 months ago
Reviewers:
Lei Zhang, open-source-third-party-reviews, darin (slow to review), cjhopman
CC:
chromium-reviews
Visibility:
Public.

Description

Revert of Add colorama to third_party/colorama (https://codereview.chromium.org/291783002/) Reason for revert: Broke the build http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Full/builds/5103 TBR=ccameron@chromium.org,cjhopman@chromium.org NOTRY=true NOTREECHECKS=true Original issue's description: > Add colorama to third_party/colorama > > colorama is a python library for colored terminal output > > BUG=374830, 374662 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275996 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276004

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -47 lines) Patch
M .gitignore View 1 chunk +0 lines, -1 line 0 comments Download
M DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/colorama/LICENSE View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/colorama/README.chromium View 1 chunk +0 lines, -13 lines 0 comments Download
M third_party/devscripts/licensecheck.pl View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/checklicenses/checklicenses.py View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
alph
Created Revert of Add colorama to third_party/colorama
6 years, 6 months ago (2014-06-10 13:16:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alph@chromium.org/328663005/1
6 years, 6 months ago (2014-06-10 13:18:51 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-10 13:18:51 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-06-10 13:18:52 UTC) #4
alph
lgtm
6 years, 6 months ago (2014-06-10 13:19:45 UTC) #5
alph
The CQ bit was checked by alph@chromium.org
6 years, 6 months ago (2014-06-10 13:19:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alph@chromium.org/328663005/1
6 years, 6 months ago (2014-06-10 13:21:45 UTC) #7
alph
The CQ bit was unchecked by alph@chromium.org
6 years, 6 months ago (2014-06-10 13:24:01 UTC) #8
alph
The CQ bit was checked by alph@chromium.org
6 years, 6 months ago (2014-06-10 13:24:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alph@chromium.org/328663005/1
6 years, 6 months ago (2014-06-10 13:24:37 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 13:27:45 UTC) #11
Message was sent while issue was closed.
Change committed as 276004

Powered by Google App Engine
This is Rietveld 408576698