IDL build: factor out interface_info actions into GYP templates

IDL build: factor out interface_info actions into GYP templates

Followup to:
IDL build: factor out global constructors action into a GYP template
https://codereview.chromium.org/319933002/

R=haraken

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176091

[Nils Barth (inactive), 2014-06-10 07:01:01]

Next GYP template factoring out.

[haraken, 2014-06-10 08:25:19]

LGTM

[haraken, 2014-06-10 08:26:06]

On 2014/06/10 08:25:19, haraken wrote:
> LGTM

However, please chat with brettw@ about when we can land this change.

[Nils Barth (inactive), 2014-06-10 08:46:11]

On 2014/06/10 08:26:06, haraken wrote:
> However, please chat with brettw@ about when we can land this change.

Won't land for now: makes no difference to generated code,
but avoids any merge conflicts from .gyp changes (Brett is adding
comments, say).

[Nils Barth (inactive), 2014-06-12 12:58:21]

Brett is finished GNifying bindings, and gave green-light to go back to work on
bindings (this doesn't conflict with his work anyway), so landing.

[Nils Barth (inactive), 2014-06-12 12:58:26]

The CQ bit was checked by nbarth@chromium.org

[commit-bot: I haz the power, 2014-06-12 12:59:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/nbarth@chromium.org/328643002/20001

[commit-bot: I haz the power, 2014-06-12 13:00:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-12 13:00:09]

Failed to apply patch for Source/bindings/modules/generated.gyp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/bindings/modules/generated.gyp
  Hunk #1 FAILED at 200.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/bindings/modules/generated.gyp.rej

Patch:       Source/bindings/modules/generated.gyp
Index: Source/bindings/modules/generated.gyp
diff --git a/Source/bindings/modules/generated.gyp
b/Source/bindings/modules/generated.gyp
index
096130be78fce869a365a54d4d38689cab89def7..cd17cd7a71e04d5724fc33ac9e0f5e2d07d6795e
100644
--- a/Source/bindings/modules/generated.gyp
+++ b/Source/bindings/modules/generated.gyp
@@ -200,71 +200,35 @@

################################################################################
   {
     'target_name': 'interfaces_info_individual_modules',
-    'type': 'none',
     'dependencies': [
       'modules_core_global_constructors_idls',
       'modules_global_constructors_idls',
     ],
-    'actions': [{
-      'action_name': 'compute_interfaces_info_individual_modules',
-      'inputs': [
-        '<(bindings_scripts_dir)/compute_interfaces_info_individual.py',
-        '<(bindings_scripts_dir)/utilities.py',
-        '<(modules_static_idl_files_list)',
-        '<@(modules_static_idl_files)',
-        '<@(modules_generated_idl_files)',
-      ],
-      'outputs': [
-       
'<(bindings_modules_output_dir)/InterfacesInfoModulesIndividual.pickle',
-      ],
-      'action': [
-        'python',
-        '<(bindings_scripts_dir)/compute_interfaces_info_individual.py',
-        '--component-dir',
-        'modules',
-        '--idl-files-list',
-        '<(modules_static_idl_files_list)',
-        '--interfaces-info-file',
+    'variables': {
+      'static_idl_files': '<(modules_static_idl_files)',
+      'generated_idl_files': '<(modules_generated_idl_files)',
+      'component_dir': 'modules',
+      'output_file':
        
'<(bindings_modules_output_dir)/InterfacesInfoModulesIndividual.pickle',
-        '--write-file-only-if-changed',
-        '<(write_file_only_if_changed)',
-        '--',
-        # Generated files must be passed at command line
-        '<@(modules_generated_idl_files)',
-      ],
-      'message': 'Computing global information about individual IDL files',
-      }]
+    },
+    'includes': ['../../bindings/scripts/interfaces_info_individual.gypi'],
   },

################################################################################
   {
     'target_name': 'interfaces_info',
-    'type': 'none',
     'dependencies': [
         '../core/generated.gyp:interfaces_info_individual_core',
         'interfaces_info_individual_modules',
     ],
-    'actions': [{
-      'action_name': 'compute_interfaces_info_overall',
-      'inputs': [
-        '<(bindings_scripts_dir)/compute_interfaces_info_overall.py',
+    'variables': {
+      'input_files': [
         '<(bindings_core_output_dir)/InterfacesInfoCoreIndividual.pickle',
        
'<(bindings_modules_output_dir)/InterfacesInfoModulesIndividual.pickle',
       ],
-      'outputs': [
-        '<(bindings_modules_output_dir)/InterfacesInfoModules.pickle',
-      ],
-      'action': [
-        'python',
-        '<(bindings_scripts_dir)/compute_interfaces_info_overall.py',
-        '--write-file-only-if-changed',
-        '<(write_file_only_if_changed)',
-        '--',
-        '<(bindings_core_output_dir)/InterfacesInfoCoreIndividual.pickle',
-       
'<(bindings_modules_output_dir)/InterfacesInfoModulesIndividual.pickle',
+      'output_file':
         '<(bindings_modules_output_dir)/InterfacesInfoModules.pickle',
-      ],
-      'message': 'Computing overall global information about IDL files',
-      }]
+    },
+    'includes': ['../../bindings/scripts/interfaces_info_overall.gypi'],
   },

################################################################################
   ],  # targets

[Nils Barth (inactive), 2014-06-12 13:00:53]

The CQ bit was checked by nbarth@chromium.org

[commit-bot: I haz the power, 2014-06-12 13:01:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/nbarth@chromium.org/328643002/40001

[commit-bot: I haz the power, 2014-06-12 14:07:05]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-06-12 14:07:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-12 14:07:29]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[Nils Barth (inactive), 2014-06-13 01:30:32]

The CQ bit was checked by nbarth@chromium.org

[commit-bot: I haz the power, 2014-06-13 01:31:41]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/nbarth@chromium.org/328643002/40001

[commit-bot: I haz the power, 2014-06-13 01:32:25]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-06-13 01:32:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-13 01:32:40]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[Nils Barth (inactive), 2014-06-13 06:38:26]

The CQ bit was checked by nbarth@chromium.org

[commit-bot: I haz the power, 2014-06-13 06:40:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/nbarth@chromium.org/328643002/40001

[commit-bot: I haz the power, 2014-06-13 08:22:40]

Change committed as 176091