Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 328553007: telemetry: Don't over-communicate in Android Systrace profiler (Closed)

Created:
6 years, 6 months ago by Sami
Modified:
6 years, 6 months ago
Reviewers:
Dominik Grewe
CC:
chromium-reviews, telemetry+watch_chromium.org
Visibility:
Public.

Description

telemetry: Don't over-communicate in Android Systrace profiler This extra call to communicate was added by mistake. Remove it and add a test. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276383

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M tools/telemetry/telemetry/core/platform/profiler/android_systrace_profiler.py View 1 chunk +0 lines, -1 line 0 comments Download
A tools/telemetry/telemetry/core/platform/profiler/android_systrace_profiler_unittest.py View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Sami
6 years, 6 months ago (2014-06-10 13:31:39 UTC) #1
Dominik Grewe
lgtm
6 years, 6 months ago (2014-06-10 13:37:21 UTC) #2
Sami
The CQ bit was checked by skyostil@chromium.org
6 years, 6 months ago (2014-06-10 13:49:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/328553007/1
6 years, 6 months ago (2014-06-10 13:50:46 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-10 21:24:05 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-10 21:51:33 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/161306)
6 years, 6 months ago (2014-06-10 21:51:34 UTC) #7
Sami
The CQ bit was checked by skyostil@chromium.org
6 years, 6 months ago (2014-06-11 10:55:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/328553007/1
6 years, 6 months ago (2014-06-11 10:56:07 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 12:25:28 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 13:42:45 UTC) #11
Message was sent while issue was closed.
Change committed as 276383

Powered by Google App Engine
This is Rietveld 408576698