Sign extend the dehoisted key at the definition point for x64 port only; for x32 port, we need to si

Sign extend the dehoisted key at the definition point for x64 port only; for x32 port, we need to sign extend the dehoisted key at the use points.

R=verwaest@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=21806

[haitao.feng, 2014-06-10 10:03:02]

The key is handled at https://codereview.chromium.org/324913002/.

[Jakob Kummerow, 2014-06-10 12:01:17]

DBC.

https://codereview.chromium.org/328553005/diff/1/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):

https://codereview.chromium.org/328553005/diff/1/src/x64/lithium-codegen-x64....
src/x64/lithium-codegen-x64.cc:278: ASSERT(kPointerSize == kInt64Size);
Please use STATIC_ASSERT when you can.

[haitao.feng, 2014-06-10 12:47:22]

Jakob, thanks for the comment.

For the x32 port, the kPointerSize is 4 bytes instead of 8 byte. If we use
STATIC_ASSERT, the x32 build will fail. The assertion here is to make sure this
function is not called in the x32 port.

On 2014/06/10 12:01:17, Jakob wrote:
> DBC.
> 
>
https://codereview.chromium.org/328553005/diff/1/src/x64/lithium-codegen-x64.cc
> File src/x64/lithium-codegen-x64.cc (right):
> 
>
https://codereview.chromium.org/328553005/diff/1/src/x64/lithium-codegen-x64....
> src/x64/lithium-codegen-x64.cc:278: ASSERT(kPointerSize == kInt64Size);
> Please use STATIC_ASSERT when you can.

[Jakob Kummerow, 2014-06-10 13:54:23]

On 2014/06/10 12:47:22, haitao.feng wrote:
> For the x32 port, the kPointerSize is 4 bytes instead of 8 byte. If we use
> STATIC_ASSERT, the x32 build will fail. The assertion here is to make sure
this
> function is not called in the x32 port.

I see. Might be worth adding a comment, so that nobody tries to "clean this up"
in the future. Maybe: "Can't use STATIC_ASSERT here because of x32."

[haitao.feng, 2014-06-11 02:44:22]

Comments added.

https://codereview.chromium.org/328553005/diff/1/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):

https://codereview.chromium.org/328553005/diff/1/src/x64/lithium-codegen-x64....
src/x64/lithium-codegen-x64.cc:278: ASSERT(kPointerSize == kInt64Size);
On 2014/06/10 12:01:17, Jakob wrote:
> Please use STATIC_ASSERT when you can.

Done.

[Toon Verwaest, 2014-06-12 08:53:02]

lgtm

[haitao.feng, 2014-06-12 12:00:32]

Committed patchset #2 manually as r21806.