Issue 328533003: Fix RenderObject::repaintRectangle in situations when the render object is not a layer and is squas…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 328533003: Fix RenderObject::repaintRectangle in situations when the render object is not a layer and is squas… (Closed)

Created:
6 years, 6 months ago by chrishtr

Modified:
6 years, 6 months ago

Reviewers:
leviw_travelin_and_unemployed

CC:
abarth-chromium, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Fix RenderObject::repaintRectangle in situations when the render object is not a layer and is squashed. Previously it was recording a repaint rect in the coordinate space of the enclosing *squashed* layer, not the coordinate space of the *squashing layer* that the squashed layer paints into. BUG=382129 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175843

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -20 lines)			Patch
A	LayoutTests/compositing/squashing/repaint-squashed-layer-in-rect.html	View	1	1 chunk	+44 lines, -0 lines	0 comments	Download
A +	LayoutTests/compositing/squashing/repaint-squashed-layer-in-rect-expected.txt	View	1 2 3	2 chunks	+9 lines, -8 lines	0 comments	Download
M	Source/core/rendering/RenderLayer.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/rendering/RenderLayer.cpp	View		3 chunks	+6 lines, -6 lines	0 comments	Download
M	Source/core/rendering/RenderObject.cpp	View		1 chunk	+1 line, -4 lines	0 comments	Download