Introduce use counters for Blink specific editing event usage

Introduce use counters for Blink specific editing event usage

This patch introduces Blink specific editing events usage with |addEventListener| for
 - textInput
 - webkitBeforeTextInserted
 - webkitEditableContentChanged

We would like to deprecate these Blink specific events and replace them standard one, e.g. beforeinput, or use another way to implement editing functionality if community agreed.

The usage data collected from use counter introduced by this patch are important for decision.

BUG=382814
TEST=n/a

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175945

[yosin_UTC9, 2014-06-10 08:03:22]

Could you review this patch?
Thanks in advance.

[tkent, 2014-06-10 08:20:00]

https://codereview.chromium.org/328513004/diff/1/Source/core/events/EventTarg...
File Source/core/events/EventTarget.cpp (right):

https://codereview.chromium.org/328513004/diff/1/Source/core/events/EventTarg...
Source/core/events/EventTarget.cpp:108: if (eventType ==
EventTypeNames::textInput) {
EventTarget is a generic interface, and I feel adding feature-specific code like
this is not suitable.
Can you move the code to Editor, and call it from here?
Something like...

  if (DOMWInodow* window = executingWindow())
      window->frame()->editor().countEvents(eventType)


Also, you should count EventTarget::fireEventListeners rather than
addEventListeners because we can attach a listener to an ancestor node of the
target node.

[yosin_UTC9, 2014-06-11 00:48:20]

PTAL

- Move count logic to Editor class
- Introduce enclosingTextFormControl(Node*) in addition to
enclosingTextFormControl(const Position&) for mapping Event.target to
INPUT/TEXTAREA for counting.

https://codereview.chromium.org/328513004/diff/1/Source/core/events/EventTarg...
File Source/core/events/EventTarget.cpp (right):

https://codereview.chromium.org/328513004/diff/1/Source/core/events/EventTarg...
Source/core/events/EventTarget.cpp:108: if (eventType ==
EventTypeNames::textInput) {
On 2014/06/10 08:19:59, tkent wrote:
> EventTarget is a generic interface, and I feel adding feature-specific code
like
> this is not suitable.
> Can you move the code to Editor, and call it from here?
> Something like...
> 
>   if (DOMWInodow* window = executingWindow())
>       window->frame()->editor().countEvents(eventType)
> 
> 
> Also, you should count EventTarget::fireEventListeners rather than
> addEventListeners because we can attach a listener to an ancestor node of the
> target node.

Done.

[tkent, 2014-06-11 01:05:48]

lgtm

https://codereview.chromium.org/328513004/diff/20001/Source/core/editing/Edit...
File Source/core/editing/Editor.cpp (right):

https://codereview.chromium.org/328513004/diff/20001/Source/core/editing/Edit...
Source/core/editing/Editor.cpp:934: if (node->hasTagName(HTMLNames::inputTag)) {
You can omit HTMLNames::.
Or, use isHTMLElement(node).

https://codereview.chromium.org/328513004/diff/20001/Source/core/editing/Edit...
Source/core/editing/Editor.cpp:939: if
(node->hasTagName(HTMLNames::textareaTag)) {
Ditto.

https://codereview.chromium.org/328513004/diff/20001/Source/core/editing/Edit...
Source/core/editing/Editor.cpp:945: if (control &&
control->hasTagName(HTMLNames::inputTag)) {
You can write |if (isHTMLInputElement(control))|.

https://codereview.chromium.org/328513004/diff/20001/Source/core/editing/Edit...
Source/core/editing/Editor.cpp:950: if (control &&
control->hasTagName(HTMLNames::textareaTag)) {
Ditto.

https://codereview.chromium.org/328513004/diff/20001/Source/core/frame/UseCou...
File Source/core/frame/UseCounter.h (right):

https://codereview.chromium.org/328513004/diff/20001/Source/core/frame/UseCou...
Source/core/frame/UseCounter.h:441: // Editing related Blink specific events.
I don't think this comment is necessary.

[tkent, 2014-06-11 01:06:36]

https://codereview.chromium.org/328513004/diff/20001/Source/core/editing/Edit...
File Source/core/editing/Editor.cpp (right):

https://codereview.chromium.org/328513004/diff/20001/Source/core/editing/Edit...
Source/core/editing/Editor.cpp:934: if (node->hasTagName(HTMLNames::inputTag)) {
On 2014/06/11 01:05:48, tkent wrote:
> You can omit HTMLNames::.
> Or, use isHTMLElement(node).

oops, isHTMLElement -> isHTMLInputElement

[yosin_UTC9, 2014-06-11 02:23:20]

Thanks for reviewing!
Committing...

https://codereview.chromium.org/328513004/diff/20001/Source/core/editing/Edit...
File Source/core/editing/Editor.cpp (right):

https://codereview.chromium.org/328513004/diff/20001/Source/core/editing/Edit...
Source/core/editing/Editor.cpp:934: if (node->hasTagName(HTMLNames::inputTag)) {
On 2014/06/11 01:06:36, tkent wrote:
> On 2014/06/11 01:05:48, tkent wrote:
> > You can omit HTMLNames::.
> > Or, use isHTMLElement(node).
> 
> oops, isHTMLElement -> isHTMLInputElement

Done.

https://codereview.chromium.org/328513004/diff/20001/Source/core/editing/Edit...
Source/core/editing/Editor.cpp:939: if
(node->hasTagName(HTMLNames::textareaTag)) {
On 2014/06/11 01:05:48, tkent wrote:
> Ditto.

Done.

https://codereview.chromium.org/328513004/diff/20001/Source/core/editing/Edit...
Source/core/editing/Editor.cpp:945: if (control &&
control->hasTagName(HTMLNames::inputTag)) {
On 2014/06/11 01:05:48, tkent wrote:
> You can write |if (isHTMLInputElement(control))|.

Done.

https://codereview.chromium.org/328513004/diff/20001/Source/core/editing/Edit...
Source/core/editing/Editor.cpp:950: if (control &&
control->hasTagName(HTMLNames::textareaTag)) {
On 2014/06/11 01:05:48, tkent wrote:
> Ditto.

Done.

https://codereview.chromium.org/328513004/diff/20001/Source/core/frame/UseCou...
File Source/core/frame/UseCounter.h (right):

https://codereview.chromium.org/328513004/diff/20001/Source/core/frame/UseCou...
Source/core/frame/UseCounter.h:441: // Editing related Blink specific events.
On 2014/06/11 01:05:48, tkent wrote:
> I don't think this comment is necessary.

Done.

[yosin_UTC9, 2014-06-11 04:18:09]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2014-06-11 04:19:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yosin@chromium.org/328513004/40001

[commit-bot: I haz the power, 2014-06-11 06:17:43]

Change committed as 175945