Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 328483004: Remove BluetoothServiceRecord base class. (Closed)

Created:
6 years, 6 months ago by keybuk
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Remove BluetoothServiceRecord base class. Since only a Windows implementation remains, move the methods that platform uses into BluetoothServiceRecordWin and delete the base class. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276915

Patch Set 1 #

Patch Set 2 : Add missing include #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -94 lines) Patch
M device/bluetooth/bluetooth.gyp View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_device_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D device/bluetooth/bluetooth_service_record.h View 1 chunk +0 lines, -71 lines 0 comments Download
D device/bluetooth/bluetooth_service_record.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M device/bluetooth/bluetooth_service_record_win.h View 1 1 chunk +26 lines, -5 lines 0 comments Download

Messages

Total messages: 31 (0 generated)
keybuk
armansito: general /bluetooth/ rpaquay, xiyuan: _win isherman: _mac
6 years, 6 months ago (2014-06-09 20:46:25 UTC) #1
Ilya Sherman
LGTM :D
6 years, 6 months ago (2014-06-09 21:09:28 UTC) #2
rpaquay
lgtm
6 years, 6 months ago (2014-06-10 22:39:31 UTC) #3
keybuk
The CQ bit was checked by keybuk@chromium.org
6 years, 6 months ago (2014-06-10 22:43:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keybuk@chromium.org/328483004/20001
6 years, 6 months ago (2014-06-10 22:44:40 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 08:46:25 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 12:15:18 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/25817)
6 years, 6 months ago (2014-06-11 12:15:19 UTC) #8
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 6 months ago (2014-06-11 17:29:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keybuk@chromium.org/328483004/20001
6 years, 6 months ago (2014-06-11 17:32:14 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 20:03:23 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 20:23:47 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/26054)
6 years, 6 months ago (2014-06-11 20:23:48 UTC) #13
keybuk
The CQ bit was checked by keybuk@chromium.org
6 years, 6 months ago (2014-06-11 20:45:09 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keybuk@chromium.org/328483004/20001
6 years, 6 months ago (2014-06-11 20:48:46 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 20:56:15 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 21:00:37 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/26113)
6 years, 6 months ago (2014-06-11 21:00:38 UTC) #18
keybuk
The CQ bit was checked by keybuk@chromium.org
6 years, 6 months ago (2014-06-11 22:52:36 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keybuk@chromium.org/328483004/20001
6 years, 6 months ago (2014-06-11 22:54:14 UTC) #20
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 23:01:14 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 23:18:28 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/26286)
6 years, 6 months ago (2014-06-11 23:18:30 UTC) #23
keybuk
The CQ bit was checked by keybuk@chromium.org
6 years, 6 months ago (2014-06-12 17:49:57 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keybuk@chromium.org/328483004/20001
6 years, 6 months ago (2014-06-12 17:53:13 UTC) #25
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-12 18:12:51 UTC) #26
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-12 18:27:41 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/26726)
6 years, 6 months ago (2014-06-12 18:27:42 UTC) #28
keybuk
The CQ bit was checked by keybuk@chromium.org
6 years, 6 months ago (2014-06-12 18:29:49 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keybuk@chromium.org/328483004/40001
6 years, 6 months ago (2014-06-12 18:31:15 UTC) #30
commit-bot: I haz the power
6 years, 6 months ago (2014-06-13 03:59:02 UTC) #31
Message was sent while issue was closed. 
Change committed as 276915

Powered by Google App Engine
This is Rietveld 408576698