Issue 328453003: Refactor to remove unnecessary code from the string hashing functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 328453003: Refactor to remove unnecessary code from the string hashing functions (Closed)

Created:
6 years, 6 months ago by atreat

Modified:
6 years, 6 months ago

Reviewers:
tkent, eseidel, Inactive, abarth-chromium

CC:
blink-reviews, blink-reviews-wtf_chromium.org, Mikhail, abarth-chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Refactor to remove unnecessary code from the string hashing functions Previously, StringHasher contained methods for calculating the hash of a pure C character array without having to pass in the length of the array. This was only used for AtomicStrings constructed via a string literal. The impl of the specific hashing function currently used in WTF already checks for null terminated character array and when the final StringImpl* for the AtomicString is constructed we do so again. This patch just computes the length up front and passes that information along to the hashing function. Eventually this length is used to construct the StringImpl without computing again. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175826

Patch Set 1 #

Patch Set 2 : Fix the unit tests #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -122 lines)			Patch
M	Source/wtf/StringHasher.h	View		4 chunks	+0 lines, -57 lines	0 comments	Download
M	Source/wtf/StringHasherTest.cpp	View	1	14 chunks	+9 lines, -45 lines	0 comments	Download
M	Source/wtf/text/AtomicString.cpp	View		2 chunks	+1 line, -20 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adam.treat@samsung.com/328453003/20001

6 years, 6 months ago (2014-06-09 22:02:41 UTC) #4

Message was sent while issue was closed.

Change committed as 175826

Expand Messages | Collapse Messages