Remove impossible conditions from SelectorChecker::checkOne()

Remove impossible conditions from SelectorChecker::checkOne()

Remove impossible conditions from SelectorChecker::checkOne(). The code is in
an if "(selector.m_match == CSSSelector::PseudoClass)" check scope so it is
impossible for "selector.m_match == CSSSelector::Tag" to ever be true in
the two conditions that are removed.

This is based the following WebKit revision by benjamin@webkit.org:
http://trac.webkit.org/changeset/156380

R=esprehn@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175839

[esprehn, 2014-06-09 21:41:35]

https://codereview.chromium.org/328443003/diff/1/Source/core/css/SelectorChec...
File Source/core/css/SelectorChecker.cpp (right):

https://codereview.chromium.org/328443003/diff/1/Source/core/css/SelectorChec...
Source/core/css/SelectorChecker.cpp:789: // href and *:hover should not match
anything. This is important for sites like wsj.com.
I suspect the wjs.com website has long since changed, what does Firefox do here?
Can we just remove this silly quirks mode behavior?

[Inactive, 2014-06-10 00:35:05]

https://codereview.chromium.org/328443003/diff/1/Source/core/css/SelectorChec...
File Source/core/css/SelectorChecker.cpp (right):

https://codereview.chromium.org/328443003/diff/1/Source/core/css/SelectorChec...
Source/core/css/SelectorChecker.cpp:789: // href and *:hover should not match
anything. This is important for sites like wsj.com.
On 2014/06/09 21:41:35, esprehn wrote:
> I suspect the http://wjs.com website has long since changed, what does Firefox
do here?
> Can we just remove this silly quirks mode behavior?

Unfortunately, based on my testing, out behavior in quirks mode here seems to
match Firefox's.

[esprehn, 2014-06-10 00:47:58]

lgtm

[Inactive, 2014-06-10 00:52:40]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-06-10 00:53:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/328443003/1

[commit-bot: I haz the power, 2014-06-10 01:02:52]

Change committed as 175839