Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 328383003: Revert of Introduce SessionManager that will contain code to start user session on Chrome OS (Closed)

Created:
6 years, 6 months ago by please use gerrit instead
Modified:
6 years, 6 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org, xiyuan, zel
Visibility:
Public.

Description

Revert of Introduce SessionManager that will contain code to start user session on Chrome OS (https://codereview.chromium.org/318853004/) Reason for revert: Appears to have broken the kiosk and auth browser tests in http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/30916 Original issue's description: > Introduce SessionManager that will contain code to start user session on Chrome OS > > Move profile creation / session initialization (prefs/RLZ) as well as some of OAuth session init > related code from LoginUtils to SessionManager. LoginUtils will temporarily implement > SessionManager::Delegate interface till existing test coverage is migrated from LoginUtils interface. > SessionManager will later use concept of UserSession (see design proposal at http://goto/cros-login-c14n). > > LoginUtils::OnPrepareProfile() is split into > StartSession() > --PreStartSession() - things like switching logging dest > --CreateUserSession() - will eventually create UserSession instance > --StartCrosSession() - notify cros::SessionManager > --NotifyUserLoggedIn() - UserManager::UserLoggedIn() > --PrepareProfile() > > PrepareProfile() - calls PM::CreateProfileAsync() > --OnProfileCreated() > ----InitProfilePreferences() - early initialization > ----UserProfileInitialized() > ------transfer signin profile auth date (cookies/proxy auth/certs) > ------RestoreAuthSessionImpl() - OAuth2LoginManager::RestoreSession() > ----FinalizePrepareProfile(() > ------Own TPM (if it didn't happen for some reason) > ------Notify SAML offline signin limiter > ------Notify ProfileImpl > ------chrome::NOTIFICATION_LOGIN_USER_PROFILE_PREPARED > ------InitRLZ (for primary user) > > > Minor cleanup > * Unify DemoApp profile initialization flow with regular one > * Don't pass display_email to LoginUtils::PrepareProfile > * Move powerwash related prefs registration to ResetScreenHandler > * Cleanup M31 migration code for |prefs::kProfileIsManaged| in LoginUtilsImpl::InitProfilePreferences() > > BUG=370175, 276163 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276626 TBR=antrim@chromium.org,bauerb@chromium.org,nkostylev@chromium.org NOTREECHECKS=true NOTRY=true BUG=370175, 276163 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276760

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+643 lines, -826 lines) Patch
M chrome/browser/chromeos/app_mode/kiosk_profile_loader.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 1 chunk +3 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/fake_login_utils.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/fake_login_utils.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.h View 5 chunks +18 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 11 chunks +572 lines, -36 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/mock_login_utils.h View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/mock_login_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/chromeos/login/session/session_manager.h View 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/browser/chromeos/login/session/session_manager.cc View 1 chunk +0 lines, -577 lines 0 comments Download
M chrome/browser/chromeos/login/test_login_utils.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/test_login_utils.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/users/user_manager_impl.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/preferences.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/reset_screen_handler.h View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
please use gerrit instead
Created Revert of Introduce SessionManager that will contain code to start user session on Chrome ...
6 years, 6 months ago (2014-06-12 18:02:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/328383003/1
6 years, 6 months ago (2014-06-12 18:10:21 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 18:40:18 UTC) #3
Message was sent while issue was closed.
Change committed as 276760

Powered by Google App Engine
This is Rietveld 408576698