Issue 328363003: Use the managed bookmarks icon for its folder in views.

Issue 328363003: Use the managed bookmarks icon for its folder in views. (Closed)

Created:
6 years, 6 months ago by Joao da Silva

Modified:
6 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Use the managed bookmarks icon for its folder in views. BUG=379862 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278507

Patch Set 5 : cleanup #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -12 lines)			Patch
M	chrome/app/theme/theme_resources.grd	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc	View	1 2	2 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.h	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc	View	1 2 3	3 chunks	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Joao da Silva

Hi Scott, one more :-) This one fixes the icon of the managed bookmarks folder. ...

6 years, 6 months ago (2014-06-18 19:52:52 UTC) #1

sky

https://codereview.chromium.org/328363003/diff/20001/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc File chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc (right): https://codereview.chromium.org/328363003/diff/20001/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc#newcode446 chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc:446: BuildMenuForPermanentNode(model->other_node(), folder_icon, menu, How about making this take the ...

6 years, 6 months ago (2014-06-19 15:02:55 UTC) #2

Joao da Silva

This has been rebased and the diff has a lot of noise now, but the ...

6 years, 6 months ago (2014-06-19 15:56:35 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/328363003/80001

6 years, 6 months ago (2014-06-19 20:39:47 UTC) #6

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_clang_dbg on tryserver.chromium ...

6 years, 6 months ago (2014-06-19 21:56:31 UTC) #7

Message was sent while issue was closed.

Change committed as 278507

Expand Messages | Collapse Messages