Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1217)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 328343005: Fix python build util script exception (Closed)

Created:
6 years, 6 months ago by hush (inactive)
Modified:
6 years, 6 months ago
Reviewers:
cjhopman, newt (away)
CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix python build util script exception BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277268

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/android/gyp/util/build_utils.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hush (inactive)
You will get "Python TypeError: not enough arguments for format string" if checkZipPath does raise ...
6 years, 6 months ago (2014-06-14 01:05:14 UTC) #1
cjhopman
lgtm
6 years, 6 months ago (2014-06-14 01:08:48 UTC) #2
hush (inactive)
The CQ bit was checked by hush@chromium.org
6 years, 6 months ago (2014-06-14 01:18:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hush@chromium.org/328343005/1
6 years, 6 months ago (2014-06-14 01:21:42 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-14 20:26:34 UTC) #5
Message was sent while issue was closed. 
Change committed as 277268

Powered by Google App Engine
This is Rietveld 408576698