Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 328343003: Remove dependency on Vector from platform files (Closed)

Created:
6 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Remove dependency on Vector from platform files Add wrappers to utils.h instead. BUG=none R=jkummerow@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=21846

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : updates #

Total comments: 1

Patch Set 4 : updates #

Patch Set 5 : updates #

Patch Set 6 : updates #

Patch Set 7 : updates #

Patch Set 8 : updates #

Patch Set 9 : updates #

Patch Set 10 : updates #

Patch Set 11 : updates #

Patch Set 12 : updates #

Patch Set 13 : updates #

Patch Set 14 : updates #

Patch Set 15 : updates #

Patch Set 16 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+453 lines, -480 lines) Patch
M src/arm/disasm-arm.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 20 chunks +86 lines, -90 lines 0 comments Download
M src/arm64/disasm-arm64.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/ast.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +1 line, -1 line 0 comments Download
M src/disassembler.cc View 1 2 3 4 5 3 chunks +12 lines, -12 lines 0 comments Download
M src/extensions/gc-extension.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gdb-jit.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M src/heap-snapshot-generator.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M src/hydrogen.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +5 lines, -5 lines 0 comments Download
M src/ia32/disasm-ia32.cc View 3 chunks +9 lines, -10 lines 0 comments Download
M src/isolate.h View 1 chunk +5 lines, -5 lines 0 comments Download
M src/log.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 4 chunks +4 lines, -4 lines 0 comments Download
M src/log-utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/mips/disasm-mips.cc View 6 chunks +17 lines, -17 lines 0 comments Download
M src/objects.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +1 line, -1 line 0 comments Download
M src/platform.h View 1 2 3 4 5 6 7 8 4 chunks +6 lines, -11 lines 0 comments Download
M src/platform-posix.cc View 2 chunks +10 lines, -9 lines 0 comments Download
M src/platform-solaris.cc View 1 chunk +0 lines, -38 lines 0 comments Download
M src/platform-win32.cc View 1 2 3 4 5 6 7 5 chunks +16 lines, -16 lines 0 comments Download
M src/prettyprinter.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 4 chunks +13 lines, -13 lines 0 comments Download
M src/profile-generator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/snapshot-common.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/string-stream.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/utils.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +7 lines, -0 lines 0 comments Download
M src/utils.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +20 lines, -1 line 0 comments Download
M src/version.cc View 2 chunks +11 lines, -11 lines 0 comments Download
M src/x64/disasm-x64.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/x87/disasm-x87.cc View 3 chunks +5 lines, -10 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 3 4 17 chunks +64 lines, -64 lines 0 comments Download
M test/cctest/test-compiler.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-debug.cc View 1 2 3 4 15 chunks +43 lines, -43 lines 0 comments Download
M test/cctest/test-deoptimization.cc View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M test/cctest/test-heap.cc View 1 2 3 4 5 6 15 chunks +28 lines, -29 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-log.cc View 1 2 3 4 5 6 7 8 9 3 chunks +13 lines, -13 lines 0 comments Download
M test/cctest/test-log-stack-tracer.cc View 1 2 3 4 1 chunk +6 lines, -6 lines 0 comments Download
M test/cctest/test-mementos.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 3 chunks +10 lines, -10 lines 0 comments Download
M test/cctest/test-profile-generator.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-serialize.cc View 1 2 3 4 6 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/test-utils.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-weaktypedarrays.cc View 1 2 3 4 5 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
6 years, 6 months ago (2014-06-12 19:09:39 UTC) #1
jochen (gone - plz use gerrit)
https://codereview.chromium.org/328343003/diff/50001/src/platform-solaris.cc File src/platform-solaris.cc (left): https://codereview.chromium.org/328343003/diff/50001/src/platform-solaris.cc#oldcode149 src/platform-solaris.cc:149: static int StackWalkCallback(uintptr_t pc, int signo, void* data) { ...
6 years, 6 months ago (2014-06-12 20:37:19 UTC) #2
Jakob Kummerow
lgtm
6 years, 6 months ago (2014-06-13 09:31:48 UTC) #3
jochen (gone - plz use gerrit)
6 years, 6 months ago (2014-06-13 16:43:45 UTC) #4
Message was sent while issue was closed. 
Committed patchset #16 manually as r21846 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698