Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 328343002: Remove SkPicture SK_SUPPORT_LEGACY_RECORDING_FLAG flag (Closed)

Created:
6 years, 6 months ago by robertphillips
Modified:
6 years, 6 months ago
Reviewers:
mtklein, scroggo, bsalomon, reed1
CC:
reviews_skia.org, scroggo
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Remove SkPicture SK_SUPPORT_LEGACY_RECORDING_FLAG flag Chromium/Blink should no longer need this flag after: Chromium: Remove use of kUsePathBoundsForClip_RecordingFlag https://codereview.chromium.org/322123002/ Blink: Remove use of kUsePathBoundsForClip_RecordingFlag https://codereview.chromium.org/326953002/ Committed: https://skia.googlesource.com/skia/+/02830f0448ce1af077cedc552e913f464834e455

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M gyp/skia_for_chromium_defines.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkPicture.h View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
robertphillips
6 years, 6 months ago (2014-06-12 14:59:01 UTC) #1
robertphillips
6 years, 6 months ago (2014-06-12 14:59:46 UTC) #2
scroggo
lgtm
6 years, 6 months ago (2014-06-12 15:01:53 UTC) #3
mtklein
lgtm
6 years, 6 months ago (2014-06-12 15:09:53 UTC) #4
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 6 months ago (2014-06-12 18:33:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/328343002/1
6 years, 6 months ago (2014-06-12 18:33:47 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-12 18:33:51 UTC) #7
commit-bot: I haz the power
Presubmit check for 328343002-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 6 months ago (2014-06-12 18:33:52 UTC) #8
robertphillips
Mike, Brian?
6 years, 6 months ago (2014-06-12 18:57:03 UTC) #9
reed1
lgtm
6 years, 6 months ago (2014-06-12 18:58:00 UTC) #10
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 6 months ago (2014-06-12 19:16:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/328343002/1
6 years, 6 months ago (2014-06-12 19:16:31 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 19:57:04 UTC) #13
Message was sent while issue was closed.
Change committed as 02830f0448ce1af077cedc552e913f464834e455

Powered by Google App Engine
This is Rietveld 408576698