Source/platform/transforms/RotateTransformOperation.h - Issue 328333003: Adding Blink-side 3d Box and Bounds calculations to TransformOperations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/transforms/RotateTransformOperation.h

Issue 328333003: Adding Blink-side 3d Box and Bounds calculations to TransformOperations (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixing android build Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/platform/transforms/PerspectiveTransformOperation.h ('k') | Source/platform/transforms/RotateTransformOperation.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/transforms/RotateTransformOperation.h

diff --git a/Source/platform/transforms/RotateTransformOperation.h b/Source/platform/transforms/RotateTransformOperation.h

index 83cd81234706c1e392a9975353734f664ee7945b..661d4b43151a48b96ba43cf6fd9169c2fc3c68f4 100644

--- a/Source/platform/transforms/RotateTransformOperation.h

+++ b/Source/platform/transforms/RotateTransformOperation.h

@@ -46,11 +46,15 @@ public:

double z() const { return m_z; }

double angle() const { return m_angle; }

-private:

- virtual bool isIdentity() const OVERRIDE { return !m_angle; }

+ FloatPoint3D axis() const;

+ static bool shareSameAxis(const RotateTransformOperation* fromRotation, const RotateTransformOperation* toRotation, FloatPoint3D* axis, double* fromAngle, double* toAngle);

+ virtual bool canBlendWith(const TransformOperation& other) const;

virtual OperationType type() const OVERRIDE { return m_type; }

+private:

+ virtual bool isIdentity() const OVERRIDE { return !m_angle; }

virtual bool operator==(const TransformOperation& o) const OVERRIDE

{

if (!isSameType(o))