Source/platform/transforms/MatrixTransformOperation.h - Issue 328333003: Adding Blink-side 3d Box and Bounds calculations to TransformOperations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/transforms/MatrixTransformOperation.h

Issue 328333003: Adding Blink-side 3d Box and Bounds calculations to TransformOperations (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/platform/geometry/FloatBoxTestHelpers.h ('K') | « Source/platform/transforms/Matrix3DTransformOperation.h ('k') | Source/platform/transforms/PerspectiveTransformOperation.h » ('j') | Source/platform/transforms/SkewTransformOperation.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/transforms/MatrixTransformOperation.h

diff --git a/Source/platform/transforms/MatrixTransformOperation.h b/Source/platform/transforms/MatrixTransformOperation.h

index ce842c13a00a42165fc255d1b1cef7acc02c4f8e..be831935f9eeed29b5f899661d47dcd7679d9719 100644

--- a/Source/platform/transforms/MatrixTransformOperation.h

+++ b/Source/platform/transforms/MatrixTransformOperation.h

@@ -44,6 +44,10 @@ public:

TransformationMatrix matrix() const { return TransformationMatrix(m_a, m_b, m_c, m_d, m_e, m_f); }

+ virtual bool canBlendWith(const TransformOperation& other) const

+ {

+ return false;

+ }

Ian Vollick 2014/06/18 15:38:06 nit: pls add a line of ws.

awoloszyn 2014/06/18 18:31:08 Done.

private:

virtual bool isIdentity() const OVERRIDE { return m_a == 1 && !m_b && !m_c && m_d == 1 && !m_e && !m_f; }