Issue 328313003: More work on content/browser GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 328313003: More work on content/browser GN build. (Closed)

Created:
6 years, 6 months ago by brettw

Modified:
6 years, 6 months ago

Reviewers:
scottmg

CC:
chromium-reviews, jam, stevenjb+watch_chromium.org, oshima+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

More work on content/browser GN build. Still not hooked up and not quite everything compiles but this should be the bulk of the functionality. BUG= R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276774

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : y #

Total comments: 1

Patch Set 4 : #

Created: 6 years, 6 months ago

	Unified diffs	Side-by-side diffs	Stats (+495 lines, -496 lines)
M	build/config/features.gni	View	1 chunk	+7 lines, -0 lines	0 comments
M	build/config/linux/BUILD.gn	View	3 chunks	+4 lines, -4 lines	0 comments
A	chromeos/BUILD.gn	View	1 chunk	+17 lines, -0 lines	0 comments
M	content/browser/BUILD.gn	View	5 chunks	+278 lines, -309 lines	0 comments
M	content/content_browser.gypi	View	11 chunks	+170 lines, -178 lines	0 comments
M	content/public/browser/BUILD.gn	View	1 chunk	+16 lines, -2 lines	0 comments
M	dbus/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments
M	third_party/protobuf/proto_library.gni	View	1 chunk	+2 lines, -2 lines	0 comments

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scottmg

lgtm https://codereview.chromium.org/328313003/diff/40001/content/browser/BUILD.gn File content/browser/BUILD.gn (right): https://codereview.chromium.org/328313003/diff/40001/content/browser/BUILD.gn#newcode59 content/browser/BUILD.gn:59: deps = [ maybe do deps more like ...

6 years, 6 months ago (2014-06-12 18:26:41 UTC) #2

Message was sent while issue was closed.

Committed patchset #4 manually as r276774.

Expand Messages | Collapse Messages