Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Issue 328303007: [Mac] Yosemite: Center the sad tab help text (Closed)

Created:
6 years, 6 months ago by Mark Mentovai
Modified:
6 years, 6 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, erikchen
Project:
chromium
Visibility:
Public.

Description

[Mac] Yosemite: Center the sad tab help text. On 10.10, NSTextView alignment set before the object contains any text has no effect. TEST=In about:crash, all of the text should be centered horizontally. BUG=386205 R=avi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278696

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/cocoa/tab_contents/sad_tab_view.mm View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Mentovai
6 years, 6 months ago (2014-06-19 21:08:14 UTC) #1
Avi (use Gerrit)
lgtm Er, sure.
6 years, 6 months ago (2014-06-19 21:12:28 UTC) #2
Mark Mentovai
6 years, 6 months ago (2014-06-20 13:23:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r278696 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698