Issue 328303005: Add needed virtual destructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 328303005: Add needed virtual destructors. (Closed)

Created:
6 years, 6 months ago by bungeman-skia

Modified:
6 years, 6 months ago

Reviewers:
mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

Add needed virtual destructors. These were found by the clang on Windows build. Committed: https://skia.googlesource.com/skia/+/d7f846bdd171e4be0c05cfe61bc4446caf5c99c6

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -0 lines)			Patch
M	src/ports/SkFontMgr_win_dw.cpp	View	3 chunks	+4 lines, -0 lines	0 comments	Download
M	src/ports/SkRemotableFontMgr_win_dw.cpp	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/utils/win/SkDWriteFontFileStream.h	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

bungeman-skia

Interestingly, all of these were due to extending COM interfaces, which have lots of virtuals, ...

6 years, 6 months ago (2014-06-19 17:16:45 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bungeman@google.com/328303005/1

6 years, 6 months ago (2014-06-19 17:48:08 UTC) #4

commit-bot: I haz the power

6 years, 6 months ago (2014-06-19 18:27:06 UTC) #5

Message was sent while issue was closed.

Change committed as d7f846bdd171e4be0c05cfe61bc4446caf5c99c6