Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1602)

Issue 328303002: Roll webrtc & libjingle 6352:6406. (Closed)

Created:
6 years, 6 months ago by no longer working on chromium
Modified:
6 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : r6406 #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
no longer working on chromium
The CQ bit was checked by xians@chromium.org
6 years, 6 months ago (2014-06-12 14:26:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/328303002/40001
6 years, 6 months ago (2014-06-12 14:29:20 UTC) #2
no longer working on chromium
Committed patchset #3 manually as r276680 (presubmit successful).
6 years, 6 months ago (2014-06-12 14:42:53 UTC) #3
jam
why did you use NOTRY=TRUE? this broke the build
6 years, 6 months ago (2014-06-12 15:50:52 UTC) #4
no longer working on chromium
6 years, 6 months ago (2014-06-12 15:56:24 UTC) #5
Message was sent while issue was closed.
On 2014/06/12 15:50:52, jam wrote:
> why did you use NOTRY=TRUE? this broke the build


Hi John, I realized it broke the trees, and had already asked Patrik to revert
the roll.

Most of the try jobs failed in "apply patch", which I though it was a flake
since nothing points to webrtc specific.

Sorry for the trouble.

Powered by Google App Engine
This is Rietveld 408576698