Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 328293002: Made the new interstitial layout more mobile-friendly (Closed)

Created:
6 years, 6 months ago by felt
Modified:
6 years, 6 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, arv+watch_chromium.org, edwardjung
Project:
chromium
Visibility:
Public.

Description

Made the new interstitial layout more mobile-friendly Shrinks the padding and image size for a smaller screen. As an added bonus, also improves RTL handling (blue button should swap sides). BUG=381260, 331453 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276727

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -3 lines) Patch
M chrome/browser/resources/ssl/interstitial_v2.css View 1 2 chunks +50 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
felt
please take a look
6 years, 6 months ago (2014-06-12 05:41:17 UTC) #1
Bernhard Bauer
lgtm https://codereview.chromium.org/328293002/diff/20001/chrome/browser/resources/ssl/interstitial_v2.css File chrome/browser/resources/ssl/interstitial_v2.css (right): https://codereview.chromium.org/328293002/diff/20001/chrome/browser/resources/ssl/interstitial_v2.css#newcode35 chrome/browser/resources/ssl/interstitial_v2.css:35: float: left; I thought there was a way ...
6 years, 6 months ago (2014-06-12 06:25:14 UTC) #2
felt
The CQ bit was checked by felt@chromium.org
6 years, 6 months ago (2014-06-12 13:49:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/328293002/40001
6 years, 6 months ago (2014-06-12 13:52:13 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-12 16:20:13 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-12 16:27:22 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/16549)
6 years, 6 months ago (2014-06-12 16:27:23 UTC) #7
felt
The CQ bit was checked by felt@chromium.org
6 years, 6 months ago (2014-06-12 16:28:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/328293002/40001
6 years, 6 months ago (2014-06-12 16:30:02 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 17:22:09 UTC) #10
Message was sent while issue was closed.
Change committed as 276727

Powered by Google App Engine
This is Rietveld 408576698