Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 328263003: Make Ctor/Dtor of ExecutionContext protected. (Closed)

Created:
6 years, 6 months ago by tyoshino (SeeGerritForStatus)
Modified:
6 years, 6 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Project:
blink
Visibility:
Public.

Description

Make Ctor/Dtor of ExecutionContext protected. BUG=305497 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176248

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M Source/core/dom/ExecutionContext.h View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
tyoshino (SeeGerritForStatus)
6 years, 6 months ago (2014-06-16 13:58:17 UTC) #1
gmorrita
On 2014/06/16 13:58:17, tyoshino wrote: lgtm
6 years, 6 months ago (2014-06-16 19:24:15 UTC) #2
gmorrita
The CQ bit was checked by morrita@google.com
6 years, 6 months ago (2014-06-16 19:24:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/328263003/1
6 years, 6 months ago (2014-06-16 19:25:17 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-16 21:34:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/7749)
6 years, 6 months ago (2014-06-16 21:34:41 UTC) #6
Hajime Morrita
lgtm.
6 years, 6 months ago (2014-06-16 22:28:50 UTC) #7
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 6 months ago (2014-06-16 22:28:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/328263003/1
6 years, 6 months ago (2014-06-16 22:29:06 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-16 22:32:12 UTC) #10
Message was sent while issue was closed. 
Change committed as 176248

Powered by Google App Engine
This is Rietveld 408576698