Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1756)

Unified Diff: Source/core/rendering/compositing/CompositingReasonFinder.cpp

Issue 328263002: Remove support for CompositingReasonPositionSticky (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/compositing/CompositingReasonFinder.cpp
diff --git a/Source/core/rendering/compositing/CompositingReasonFinder.cpp b/Source/core/rendering/compositing/CompositingReasonFinder.cpp
index 0dd4fd593e21218f5d5b5113a895fcf86d9c46b6..2b2e149c1ff5f663e8eab0b3abfe3ceb63595a7a 100644
--- a/Source/core/rendering/compositing/CompositingReasonFinder.cpp
+++ b/Source/core/rendering/compositing/CompositingReasonFinder.cpp
@@ -136,9 +136,6 @@ CompositingReasons CompositingReasonFinder::nonStyleDeterminedDirectReasons(cons
directReasons |= CompositingReasonOverflowScrollingTouch;
}
- if (requiresCompositingForPositionSticky(renderer, layer))
- directReasons |= CompositingReasonPositionSticky;
-
if (requiresCompositingForPositionFixed(renderer, layer, 0))
directReasons |= CompositingReasonPositionFixed;
@@ -156,22 +153,6 @@ bool CompositingReasonFinder::requiresCompositingForAnimation(RenderStyle* style
return style->shouldCompositeForCurrentAnimations();
}
-bool CompositingReasonFinder::requiresCompositingForPosition(RenderObject* renderer, const RenderLayer* layer, RenderLayer::ViewportConstrainedNotCompositedReason* viewportConstrainedNotCompositedReason) const
-{
- return requiresCompositingForPositionSticky(renderer, layer) || requiresCompositingForPositionFixed(renderer, layer, viewportConstrainedNotCompositedReason);
-}
-
-bool CompositingReasonFinder::requiresCompositingForPositionSticky(RenderObject* renderer, const RenderLayer* layer) const
-{
- if (!(m_compositingTriggers & ViewportConstrainedPositionedTrigger))
- return false;
- if (renderer->style()->position() != StickyPosition)
- return false;
- // FIXME: This probably isn't correct for accelerated overflow scrolling. crbug.com/361723
- // Instead it should return false only if the layer is not inside a scrollable region.
- return !layer->enclosingOverflowClipLayer(ExcludeSelf);
-}
-
bool CompositingReasonFinder::requiresCompositingForPositionFixed(RenderObject* renderer, const RenderLayer* layer, RenderLayer::ViewportConstrainedNotCompositedReason* viewportConstrainedNotCompositedReason) const
{
if (!(m_compositingTriggers & ViewportConstrainedPositionedTrigger))

Powered by Google App Engine
This is Rietveld 408576698