Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 328263002: Remove support for CompositingReasonPositionSticky (Closed)

Created:
6 years, 6 months ago by abarth-chromium
Modified:
6 years, 6 months ago
Reviewers:
esprehn
CC:
blink-reviews, blink-reviews-rendering, Rik, danakj, krit, eae+blinkwatch, jamesr, jbroman, jchaffraix+rendering, leviw+renderwatch, ojan, pdr., rwlbuis, rune+blink, Stephen Chennney, Ian Vollick, zoltan1
Project:
blink
Visibility:
Public.

Description

Remove support for CompositingReasonPositionSticky Our support for position: sticky isn't even in the experimental feature set. We shouldn't be burning time during every frame checking whether any RenderLayers have sticky position. R=esprehn@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175992

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -28 lines) Patch
M Source/core/rendering/compositing/CompositingReasonFinder.h View 2 chunks +1 line, -3 lines 0 comments Download
M Source/core/rendering/compositing/CompositingReasonFinder.cpp View 2 chunks +0 lines, -19 lines 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/CompositingReasons.h View 3 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
abarth-chromium
6 years, 6 months ago (2014-06-12 00:07:36 UTC) #1
abarth-chromium
Yes, this feature appears to be completely untested.
6 years, 6 months ago (2014-06-12 00:13:12 UTC) #2
esprehn
On 2014/06/12 at 00:13:12, abarth wrote: > Yes, this feature appears to be completely untested. ...
6 years, 6 months ago (2014-06-12 00:21:25 UTC) #3
abarth-chromium
On 2014/06/12 at 00:21:25, esprehn wrote: > On 2014/06/12 at 00:13:12, abarth wrote: > > ...
6 years, 6 months ago (2014-06-12 02:02:20 UTC) #4
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 6 months ago (2014-06-12 02:02:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/328263002/1
6 years, 6 months ago (2014-06-12 02:03:56 UTC) #6
abarth-chromium
The CQ bit was unchecked by abarth@chromium.org
6 years, 6 months ago (2014-06-12 03:32:51 UTC) #7
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 6 months ago (2014-06-12 03:32:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/328263002/1
6 years, 6 months ago (2014-06-12 03:33:48 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 05:44:35 UTC) #10
Message was sent while issue was closed.
Change committed as 175992

Powered by Google App Engine
This is Rietveld 408576698