Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 328183002: More clear comment for ValidateStructHeader. (Closed)

Created:
6 years, 6 months ago by yzshen1
Modified:
6 years, 6 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

More clear comment for ValidateStructHeader. BUG=None TEST=None R=viettrungluu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276546

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M mojo/public/cpp/bindings/lib/bindings_serialization.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/cpp/bindings/lib/bindings_serialization.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
yzshen1
Hi, Trung. Would you please take a look? Thanks!
6 years, 6 months ago (2014-06-11 18:22:55 UTC) #1
viettrungluu
lgtm
6 years, 6 months ago (2014-06-11 19:25:45 UTC) #2
yzshen1
The CQ bit was checked by yzshen@chromium.org
6 years, 6 months ago (2014-06-11 20:15:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/328183002/20001
6 years, 6 months ago (2014-06-11 20:16:30 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 21:38:40 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 21:41:12 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/160358) ios_rel_device on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds/149776) ios_rel_device_ninja ...
6 years, 6 months ago (2014-06-11 21:41:13 UTC) #7
yzshen1
6 years, 6 months ago (2014-06-12 05:41:35 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 manually as r276546 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698