Issue 328163003: Inline FloatRect::operator SkRect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 328163003: Inline FloatRect::operator SkRect. (Closed)

Created:
6 years, 6 months ago by jbroman

Modified:
6 years, 6 months ago

Reviewers:
Stephen Chennney, f(malita)

CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Inline FloatRect::operator SkRect. This is somewhat hot (about 0.8% of samples while painting glyphs), is really trivial once inlined (a few moves and a few adds). SkRect.h is a pretty lightweight header, so this shouldn't affect build times very much. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175974

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -9 lines)			Patch
	M	Source/platform/geometry/FloatRect.h	View		3 chunks	+2 lines, -3 lines	0 comments	Download
	M	Source/platform/geometry/FloatRect.cpp	View		1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jbroman

It might be better ultimately to hold SkRect in FloatRect, but this takes care of ...

6 years, 6 months ago (2014-06-11 19:18:58 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/328163003/1

6 years, 6 months ago (2014-06-11 19:24:12 UTC) #4

Message was sent while issue was closed.

Change committed as 175974

Expand Messages | Collapse Messages