Roll to android/platform/ndk/681f1b744aec1b0888f4c7a68165720db9670300

Roll to android/platform/ndk/681f1b744aec1b0888f4c7a68165720db9670300

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276663

[Anton, 2014-06-11 15:31:54]

https://codereview.chromium.org/328153002/diff/1/third_party/android_crazy_li...
File third_party/android_crazy_linker/src/src/crazy_linker_elf_relocations.cpp
(right):

https://codereview.chromium.org/328153002/diff/1/third_party/android_crazy_li...
third_party/android_crazy_linker/src/src/crazy_linker_elf_relocations.cpp:54: 
Some pointers to documentation would be helpful, wondering how to find out these
values.

https://codereview.chromium.org/328153002/diff/1/third_party/android_crazy_li...
third_party/android_crazy_linker/src/src/crazy_linker_elf_relocations.cpp:191:
if (relocations_size_) {
Google style is to say: relocations_size != 0 as it is not a bool.

Similar for relocations at L176.

https://codereview.chromium.org/328153002/diff/1/third_party/android_crazy_li...
third_party/android_crazy_linker/src/src/crazy_linker_elf_relocations.cpp:253: }
Inconsistent spacing L249 v L253.

https://codereview.chromium.org/328153002/diff/1/third_party/android_crazy_li...
third_party/android_crazy_linker/src/src/crazy_linker_elf_relocations.cpp:288: 
} else if (..) {

https://codereview.chromium.org/328153002/diff/1/third_party/android_crazy_li...
third_party/android_crazy_linker/src/src/crazy_linker_elf_relocations.cpp:326:
const ELF::Sword CRAZY_UNUSED addend = rela->r_addend;
So the UNUSED applies to the non-aarch64. I assume it is safe to do that.

https://codereview.chromium.org/328153002/diff/1/third_party/android_crazy_li...
third_party/android_crazy_linker/src/src/crazy_linker_elf_relocations.cpp:352:
break;
Its the same, is that right?

https://codereview.chromium.org/328153002/diff/1/third_party/android_crazy_li...
third_party/android_crazy_linker/src/src/crazy_linker_elf_relocations.cpp:621:
if (rel_type == 0)
Is there is no symbolic name for this type?

https://codereview.chromium.org/328153002/diff/1/third_party/android_crazy_li...
third_party/android_crazy_linker/src/src/crazy_linker_elf_relocations.cpp:715:
#endif
for consistency add // __i386__ 
also L721.

https://codereview.chromium.org/328153002/diff/1/third_party/android_crazy_li...
third_party/android_crazy_linker/src/src/crazy_linker_elf_relocations.cpp:729:
size_t map_addr,
If these things are addresses why is their type size_t?

Also below.

https://codereview.chromium.org/328153002/diff/1/third_party/android_crazy_li...
File third_party/android_crazy_linker/src/tests/bar_with_relro.cpp (right):

https://codereview.chromium.org/328153002/diff/1/third_party/android_crazy_li...
third_party/android_crazy_linker/src/tests/bar_with_relro.cpp:33: printf("%s:
Bad string at offset=%zu\n", __FUNCTION__, n);
Style guide says %"PRIuS" :-(

https://codereview.chromium.org/328153002/diff/1/third_party/android_crazy_li...
File third_party/android_crazy_linker/src/tests/foo_with_static_constructor.cpp
(right):

https://codereview.chromium.org/328153002/diff/1/third_party/android_crazy_li...
third_party/android_crazy_linker/src/tests/foo_with_static_constructor.cpp:19:
#endif
Seems like this test maybe ARM specific. Do we need an equivalent for other
platforms?

[Anton, 2014-06-11 17:16:41]

On 2014/06/11 15:31:54, Anton wrote:
>
https://codereview.chromium.org/328153002/diff/1/third_party/android_crazy_li...
> File third_party/android_crazy_linker/src/src/crazy_linker_elf_relocations.cpp
> (right):
> 
>
https://codereview.chromium.org/328153002/diff/1/third_party/android_crazy_li...
> third_party/android_crazy_linker/src/src/crazy_linker_elf_relocations.cpp:54: 
> Some pointers to documentation would be helpful, wondering how to find out
these
> values.
> 
>
https://codereview.chromium.org/328153002/diff/1/third_party/android_crazy_li...
> third_party/android_crazy_linker/src/src/crazy_linker_elf_relocations.cpp:191:
> if (relocations_size_) {
> Google style is to say: relocations_size != 0 as it is not a bool.
> 
> Similar for relocations at L176.
> 
>
https://codereview.chromium.org/328153002/diff/1/third_party/android_crazy_li...
> third_party/android_crazy_linker/src/src/crazy_linker_elf_relocations.cpp:253:
}
> Inconsistent spacing L249 v L253.
> 
>
https://codereview.chromium.org/328153002/diff/1/third_party/android_crazy_li...
> third_party/android_crazy_linker/src/src/crazy_linker_elf_relocations.cpp:288:

> } else if (..) {
> 
>
https://codereview.chromium.org/328153002/diff/1/third_party/android_crazy_li...
> third_party/android_crazy_linker/src/src/crazy_linker_elf_relocations.cpp:326:
> const ELF::Sword CRAZY_UNUSED addend = rela->r_addend;
> So the UNUSED applies to the non-aarch64. I assume it is safe to do that.
> 
>
https://codereview.chromium.org/328153002/diff/1/third_party/android_crazy_li...
> third_party/android_crazy_linker/src/src/crazy_linker_elf_relocations.cpp:352:
> break;
> Its the same, is that right?
> 
>
https://codereview.chromium.org/328153002/diff/1/third_party/android_crazy_li...
> third_party/android_crazy_linker/src/src/crazy_linker_elf_relocations.cpp:621:
> if (rel_type == 0)
> Is there is no symbolic name for this type?
> 
>
https://codereview.chromium.org/328153002/diff/1/third_party/android_crazy_li...
> third_party/android_crazy_linker/src/src/crazy_linker_elf_relocations.cpp:715:
> #endif
> for consistency add // __i386__ 
> also L721.
> 
>
https://codereview.chromium.org/328153002/diff/1/third_party/android_crazy_li...
> third_party/android_crazy_linker/src/src/crazy_linker_elf_relocations.cpp:729:
> size_t map_addr,
> If these things are addresses why is their type size_t?
> 
> Also below.
> 
>
https://codereview.chromium.org/328153002/diff/1/third_party/android_crazy_li...
> File third_party/android_crazy_linker/src/tests/bar_with_relro.cpp (right):
> 
>
https://codereview.chromium.org/328153002/diff/1/third_party/android_crazy_li...
> third_party/android_crazy_linker/src/tests/bar_with_relro.cpp:33: printf("%s:
> Bad string at offset=%zu\n", __FUNCTION__, n);
> Style guide says %"PRIuS" :-(
> 
>
https://codereview.chromium.org/328153002/diff/1/third_party/android_crazy_li...
> File
third_party/android_crazy_linker/src/tests/foo_with_static_constructor.cpp
> (right):
> 
>
https://codereview.chromium.org/328153002/diff/1/third_party/android_crazy_li...
> third_party/android_crazy_linker/src/tests/foo_with_static_constructor.cpp:19:
> #endif
> Seems like this test maybe ARM specific. Do we need an equivalent for other
> platforms?

lgtm

[simonb1, 2014-06-11 17:28:24]

The CQ bit was checked by simonb@google.com

[commit-bot: I haz the power, 2014-06-11 17:32:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/simonb@chromium.org/328153002/1

[commit-bot: I haz the power, 2014-06-11 17:32:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 17:32:22]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[bulach, 2014-06-11 17:51:57]

lgtm, thanks!

[bulach, 2014-06-11 17:52:22]

The CQ bit was checked by bulach@chromium.org

[commit-bot: I haz the power, 2014-06-11 17:54:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/simonb@chromium.org/328153002/1

[commit-bot: I haz the power, 2014-06-11 21:36:18]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-11 21:41:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 21:41:07]

Try jobs failed on following builders:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[bulach, 2014-06-12 10:04:50]

The CQ bit was checked by bulach@chromium.org

[commit-bot: I haz the power, 2014-06-12 10:07:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/simonb@chromium.org/328153002/1

[commit-bot: I haz the power, 2014-06-12 14:17:53]

Change committed as 276663

[ADJackson101752, 2016-02-16 10:11:57]

adjackson101752@gmail.com changed reviewers:
+ ADJackson101752@gmail.com

[ADJackson101752, 2016-02-16 10:11:58]

lgtm

[ADJackson101752, 2016-02-16 10:12:02]

lgtm