Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 328143004: Change branding of Quickoffice flag (Closed)

Created:
6 years, 6 months ago by Kevin Graney
Modified:
6 years, 5 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, extensions-reviews_chromium.org, jtraub
Visibility:
Public.

Description

Change branding of Quickoffice flag Changed from Quickoffice to "Office Editing for Docs, Sheets & Slides" BUG= R=kurtz@chromium.org, asargent@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282372

Patch Set 1 #

Patch Set 2 : Change flag name in header too #

Patch Set 3 : #

Patch Set 4 : Change Quickoffice branding #

Patch Set 5 : removed codereview.settings hack #

Patch Set 6 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -14 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 2 3 4 5 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 4 5 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/component_loader.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chromeos/chromeos_switches.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chromeos/chromeos_switches.cc View 1 2 3 4 5 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Kevin Graney
PTAL Screenshot of the change: https://drive.google.com/a/google.com/file/d/0B4aojKQOfdVGR0RsaGZ6Q1NwQWs/edit?usp=sharing
6 years, 6 months ago (2014-06-11 15:53:47 UTC) #1
Kevin Graney
On 2014/06/11 15:53:47, Kevin Graney wrote: > PTAL > > Screenshot of the change: > ...
6 years, 6 months ago (2014-06-11 16:32:25 UTC) #2
asargent_no_longer_on_chrome
lgtm
6 years, 5 months ago (2014-07-09 22:10:12 UTC) #3
Kevin Graney
The CQ bit was checked by kmg@google.com
6 years, 5 months ago (2014-07-10 14:38:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmg@google.com/328143004/80001
6 years, 5 months ago (2014-07-10 14:38:55 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-10 15:25:45 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-10 15:27:36 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/169081) ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/builds/27426) mac_chromium_compile_dbg ...
6 years, 5 months ago (2014-07-10 15:27:37 UTC) #8
Kevin Graney
The CQ bit was checked by kmg@google.com
6 years, 5 months ago (2014-07-10 15:56:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmg@google.com/328143004/100001
6 years, 5 months ago (2014-07-10 15:58:30 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 17:52:20 UTC) #11
Message was sent while issue was closed.
Change committed as 282372

Powered by Google App Engine
This is Rietveld 408576698