Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 328143003: Timeline: add preview of painted picture for Paint event (Closed)

Created:
6 years, 6 months ago by caseq
Modified:
6 years, 6 months ago
Reviewers:
yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Timeline: add preview of painted picture for Paint event - enable "Capture picture" check-box in Timeline capture filter when Timeline on trace events experiment is enabled; - add disabled-by-default-devtools.timeline.{picture,layers} categories to trace filter when the above is checked; - associate recorded SkPicture with the last paint event of the layer with matching id; - display pictures preview in Timeline's details view, when these are available. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176196

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -57 lines) Patch
M Source/devtools/front_end/timeline/TimelineModel.js View 1 chunk +13 lines, -0 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineModelImpl.js View 1 chunk +3 lines, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 2 chunks +6 lines, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TimelineTracingView.js View 2 chunks +19 lines, -45 lines 0 comments Download
M Source/devtools/front_end/timeline/TracingTimelineModel.js View 6 chunks +25 lines, -4 lines 0 comments Download
M Source/devtools/front_end/timeline/TracingTimelineUIUtils.js View 6 chunks +53 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
caseq
6 years, 6 months ago (2014-06-11 14:47:35 UTC) #1
yurys
lgtm
6 years, 6 months ago (2014-06-16 07:34:22 UTC) #2
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 6 months ago (2014-06-16 08:39:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/328143003/1
6 years, 6 months ago (2014-06-16 08:40:04 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-16 09:42:28 UTC) #5
Message was sent while issue was closed.
Change committed as 176196

Powered by Google App Engine
This is Rietveld 408576698