cc: Recreate TileManager in DeferredInitialize

cc: Recreate TileManager in DeferredInitialize

This is to make sure DeferredInitialize picks up any setting that affect
TileManager when a ContextProvider is present, for example,
use_gpu_rasterization.

BUG=383379
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276664

[boliu, 2014-06-11 18:26:22]

PTAL

Code path should be covered by existing tests, although I guess not with ganesh
enabled.

[danakj, 2014-06-11 18:33:43]

It seems like before this change we'd use the TileManager set up for software
mode since the context_provider() would have been null until the
DeferredInitialize happened, is that the case? Kinda wondering how anything
worked then..

[boliu, 2014-06-11 18:41:30]

On 2014/06/11 18:33:43, danakj wrote:
> It seems like before this change we'd use the TileManager set up for software
> mode since the context_provider() would have been null until the
> DeferredInitialize happened, is that the case? Kinda wondering how anything
> worked then..

Umm.....it's weird. Software mode used to create the zero copy worker pools, so
it was ok not to recreate it before ganesh.

It really doesn't matter what worker pool software mode uses though, as long as
it can accept that OnDemand task that SoftwareRenderer issues.

[danakj, 2014-06-11 18:49:17]

LGTM

https://codereview.chromium.org/328113006/diff/1/cc/trees/layer_tree_host_imp...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/328113006/diff/1/cc/trees/layer_tree_host_imp...
cc/trees/layer_tree_host_impl.cc:2037: 
This method now looks exactly the same as ReleaseGL() except for the call to the
resource_provider_ and whitespace.

Want to make these share that code then?

Can you at least make the whitespace in here match ReleaseGL() so they're more
obviously the same thing?

[boliu, 2014-06-11 20:00:04]

https://codereview.chromium.org/328113006/diff/1/cc/trees/layer_tree_host_imp...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/328113006/diff/1/cc/trees/layer_tree_host_imp...
cc/trees/layer_tree_host_impl.cc:2037: 
On 2014/06/11 18:49:17, danakj wrote:
> This method now looks exactly the same as ReleaseGL() except for the call to
the
> resource_provider_ and whitespace.
> 
> Want to make these share that code then?
> 
> Can you at least make the whitespace in here match ReleaseGL() so they're more
> obviously the same thing?

Made whitespace changes so they match

[boliu, 2014-06-11 20:00:06]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2014-06-11 20:05:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/boliu@chromium.org/328113006/20001

[commit-bot: I haz the power, 2014-06-11 21:33:38]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/15599)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/18738)

[commit-bot: I haz the power, 2014-06-11 21:37:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 21:37:01]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/15668)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/18802)

[boliu, 2014-06-12 05:31:14]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2014-06-12 05:33:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/boliu@chromium.org/328113006/20001

[commit-bot: I haz the power, 2014-06-12 10:47:10]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-06-12 14:18:33]

Change committed as 276664