Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1429)

Unified Diff: Source/devtools/front_end/components/ObjectPopoverHelper.js

Issue 328113005: DevTools: Add popover for snapshot canvas log. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/components/ObjectPopoverHelper.js
diff --git a/Source/devtools/front_end/components/ObjectPopoverHelper.js b/Source/devtools/front_end/components/ObjectPopoverHelper.js
index 9253777f1dd77506b73b67f60f63c4a2491c89f1..004d80676efbb72ea656965f401cece427e3298f 100644
--- a/Source/devtools/front_end/components/ObjectPopoverHelper.js
+++ b/Source/devtools/front_end/components/ObjectPopoverHelper.js
@@ -33,7 +33,7 @@
* @extends {WebInspector.PopoverHelper}
* @param {!Element} panelElement
* @param {function(!Element, !Event):!Element|undefined} getAnchor
- * @param {function(!Element, function(!WebInspector.RemoteObject, boolean, !Element=):undefined, string):undefined} queryObject
+ * @param {function(!Element, function(!WebInspector.RemoteObject, boolean=, !Element=):undefined, string):undefined} queryObject
caseq 2014/06/11 16:03:21 is this really necessary?
malch 2014/06/11 16:32:58 Added it because of the lint error. Removed it. On
* @param {function()=} onHide
* @param {boolean=} disableOnClick
*/
@@ -93,7 +93,7 @@ WebInspector.ObjectPopoverHelper.prototype = {
/**
* @param {!WebInspector.RemoteObject} result
- * @param {boolean} wasThrown
+ * @param {boolean=} wasThrown
* @param {!Element=} anchorOverride
* @this {WebInspector.ObjectPopoverHelper}
*/

Powered by Google App Engine
This is Rietveld 408576698